Skip to content
Snippets Groups Projects
Commit 04ef0b7d authored by Samuel GAIST's avatar Samuel GAIST
Browse files

[team][api] Implement get_object in place of get_queryset for TeamDetailView

This view only concerns one object at a time
parent 84f0b115
No related branches found
No related tags found
No related merge requests found
This commit is part of merge request !327. Comments created here will be created in the context of that merge request.
...@@ -102,7 +102,7 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView): ...@@ -102,7 +102,7 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
self.permission_classes.append(IsOwner) self.permission_classes.append(IsOwner)
return super(TeamDetailView, self).get_permissions() return super(TeamDetailView, self).get_permissions()
def get_queryset(self): def get_object(self):
owner_name = self.kwargs.get("owner_name") owner_name = self.kwargs.get("owner_name")
team_name = self.kwargs.get("team_name") team_name = self.kwargs.get("team_name")
...@@ -118,12 +118,12 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView): ...@@ -118,12 +118,12 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
return super(TeamDetailView, self).get_serializer(*args, **kwargs) return super(TeamDetailView, self).get_serializer(*args, **kwargs)
def get(self, request, owner_name, team_name): def get(self, request, owner_name, team_name):
team = self.get_queryset() team = self.get_object()
serializer = self.serializer_class(team, context={"user": request.user}) serializer = self.serializer_class(team, context={"user": request.user})
return Response(serializer.data) return Response(serializer.data)
def delete(self, request, owner_name, team_name): def delete(self, request, owner_name, team_name):
team = self.get_queryset() team = self.get_object()
# Check that the team can still be deleted # Check that the team can still be deleted
if not (team.deletable()): if not (team.deletable()):
...@@ -136,7 +136,7 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView): ...@@ -136,7 +136,7 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
return Response(status=status.HTTP_204_NO_CONTENT) return Response(status=status.HTTP_204_NO_CONTENT)
def update(self, request, owner_name, team_name): def update(self, request, owner_name, team_name):
team = self.get_queryset() team = self.get_object()
self.check_object_permissions(request, team) self.check_object_permissions(request, team)
serializer = self.writing_serializer_class( serializer = self.writing_serializer_class(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment