Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • beat.core beat.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • beat
  • beat.corebeat.core
  • Merge requests
  • !112

Improve disconnection handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Samuel GAIST requested to merge improve_disconnection_handling into master Feb 20, 2020
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 2

When reloading a worker node, the broker will notice after the usual timeout that it was gone. This is the same as if a node loses its network connection or gets killed.

This wasn't an issue before because the restart of the worker script was "slow" due to the enumeration of all BEAT related docker images. If a node uses the new labeled images, the restart is way faster and thus the broker will have an invalid state.

This patch fixes that by sending a notification to the broker that the worker node is disconnecting. This will make the broker cleanup the entry and have it ready once the worker is back online.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: improve_disconnection_handling