bob issueshttps://gitlab.idiap.ch/groups/bob/-/issues2017-10-20T02:30:36Zhttps://gitlab.idiap.ch/bob/bob.bio.face/-/issues/3Travis pip install --upgrade numpy may not be the best2017-10-20T02:30:36ZAndré AnjosTravis pip install --upgrade numpy may not be the best*Created by: anjos*
I have found that this package does a `pip install --upgrade numpy` (and other packages). For those standard packages, I think running with `--upgrade` is not a good choice.
We have wheels that are pre-compiled ag...*Created by: anjos*
I have found that this package does a `pip install --upgrade numpy` (and other packages). For those standard packages, I think running with `--upgrade` is not a good choice.
We have wheels that are pre-compiled against the numpy version which is already pre-installed on Travis virtualenvs. If you issue an `--upgrade`, it may create conflicts between the numpy version installed and that with which our SciPy wheel was compiled against.
As a suggestion, I'd completely remove this line and let the requirements to be satisfied (automatically) with the next pip installs which follow this line. If that does not work because of test requirements, I'd setup a "test.txt" requirements file and do a simple `pip install <our-idiap-wheel-repo> -r text.txt` to make sure those are installed properly.
I'm not sure other packages are the same, but we should apply the same strategy everywhere.https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/12evaluate.py segfaults with no error2018-06-03T12:14:18ZAndré Anjosevaluate.py segfaults with no error*Created by: 183amir*
I realized that when one of the score files are empty, the program segfaults with no error.*Created by: 183amir*
I realized that when one of the score files are empty, the program segfaults with no error.Amir MOHAMMADIAmir MOHAMMADIhttps://gitlab.idiap.ch/bob/bob.bio.face/-/issues/2It is not possible to set the algorithm 'ivector'2017-10-20T02:30:36ZAndré AnjosIt is not possible to set the algorithm 'ivector'*Created by: tiagofrepereira2012*
Since the bob.bio.gmm > 2.0.1 the ```bob.bio.algorithm``` resource called ```ivector``` doesn't exists anymore.
Now there are 3 variants called ```ivector-cosine```, ```ivector-plda```, and ```ivect...*Created by: tiagofrepereira2012*
Since the bob.bio.gmm > 2.0.1 the ```bob.bio.algorithm``` resource called ```ivector``` doesn't exists anymore.
Now there are 3 variants called ```ivector-cosine```, ```ivector-plda```, and ```ivector-lda-wccn-plda```.
An update is necessary in the baseline.py script in order to reflect in theses modifications.
Basically is necesary to update this line https://github.com/bioidiap/bob.bio.face/blob/master/bob/bio/face/script/baselines.py#L33https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/11script/fusion_llr.py does not get installed with setuptools2018-06-03T12:14:18ZAndré Anjosscript/fusion_llr.py does not get installed with setuptools*Created by: 183amir*
*Created by: 183amir*
https://gitlab.idiap.ch/bob/bob.bio.face/-/issues/1Nosetests fail in test_databases, when bob.db databases are not available2017-10-20T02:30:36ZAndré AnjosNosetests fail in test_databases, when bob.db databases are not available*Created by: siebenkopf*
When setting up a new package as described here:
http://pythonhosted.org/bob.bio.base/installation.html#installation-instructions
adding the ``bob.bio.face`` package, but omitting some or all of the ``bob.db``...*Created by: siebenkopf*
When setting up a new package as described here:
http://pythonhosted.org/bob.bio.base/installation.html#installation-instructions
adding the ``bob.bio.face`` package, but omitting some or all of the ``bob.db`` database interfaces, the nose tests will not pass on the omitted databases. An ``ImportError`` is raised, when the database configuration is read.
We should have a mechanism that avoids raising these import errors, at least while running the nose tests.
Also, the omitted databases are still listed in the ``./bin/resources.py``, while they are not really ready to be used. https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/10Create a test to prevent some errors for scoring tools2018-06-03T12:14:18ZAndré AnjosCreate a test to prevent some errors for scoring tools*Created by: 183amir*
https://github.com/bioidiap/bob.bio.base/commit/49da5d1a52bdb0ec53fdf11dbdda9be9688a04ac#commitcomment-16595463*Created by: 183amir*
https://github.com/bioidiap/bob.bio.base/commit/49da5d1a52bdb0ec53fdf11dbdda9be9688a04ac#commitcomment-16595463Amir MOHAMMADIAmir MOHAMMADIhttps://gitlab.idiap.ch/bob/bob.bio.base/-/issues/8Evaluation.py script has no EPC curve2018-06-03T12:14:18ZAndré AnjosEvaluation.py script has no EPC curve*Created by: tiagofrepereira2012*
I just noticed that the `./evaluate.py` script has no option to plot the EPC.
Is there any special reason for that?
I know that this script works fine if we provide, as input, only `--dev-files` and...*Created by: tiagofrepereira2012*
I just noticed that the `./evaluate.py` script has no option to plot the EPC.
Is there any special reason for that?
I know that this script works fine if we provide, as input, only `--dev-files` and to plot the EPC we need both (dev and eval).
If this is the reason to not have it, I can just output a warning saying that (if you set the `--epc` with no `--eval-files`).
Anyways, I can implement it, no problem.
https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/4DatabaseBob.py : method fails if model_id has the label '0'2018-06-03T12:14:18ZAndré AnjosDatabaseBob.py : method fails if model_id has the label '0'*Created by: tiagofrepereira2012*
There is a flaw in the method `probe_file_sets` in the script bellow.
https://github.com/bioidiap/bob.bio.base/blob/master/bob/bio/base/database/DatabaseBob.py#L328
Depending of the database the met...*Created by: tiagofrepereira2012*
There is a flaw in the method `probe_file_sets` in the script bellow.
https://github.com/bioidiap/bob.bio.base/blob/master/bob/bio/base/database/DatabaseBob.py#L328
Depending of the database the method will never return the correct probes if the model_id is actually `0`.
This test should be replaced by a wiser test
```
if model_id is not None:
```
A patch is on the way.https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/2score fusion script2020-03-26T10:27:10ZAndré Anjosscore fusion script*Created by: khoury*
The fusion script is currently in bob.bio.spear.
I think it's wiser to put it here but please let me know if someone has different point of view.
*Created by: khoury*
The fusion script is currently in bob.bio.spear.
I think it's wiser to put it here but please let me know if someone has different point of view.
https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/1unnecessary files are processed in the parallel implementation2018-06-03T12:14:18ZAndré Anjosunnecessary files are processed in the parallel implementation*Created by: khoury*
It seems that the 'groups' argument is overwritten by its defaults value ('dev') while running the parallel implementation.
Changes in bob/bio/base/script/verify.py are needed.*Created by: khoury*
It seems that the 'groups' argument is overwritten by its defaults value ('dev') while running the parallel implementation.
Changes in bob/bio/base/script/verify.py are needed.https://gitlab.idiap.ch/bob/bob.ap/-/issues/1Questionable implementation of DCT kernel in Ceps.cpp2017-08-17T14:18:22ZAndré AnjosQuestionable implementation of DCT kernel in Ceps.cpp*Created by: pkorshunov*
@laurentes and @khoury: Could you please check this issue?
DCT kernel is implemented in Ceps.cpp (see line 103):
m_dct_kernel = dct_coeff * blitz::cos(M_PI*(i+1)*(j+0.5)/(double)(m_n_filters));
I'm ...*Created by: pkorshunov*
@laurentes and @khoury: Could you please check this issue?
DCT kernel is implemented in Ceps.cpp (see line 103):
m_dct_kernel = dct_coeff * blitz::cos(M_PI*(i+1)*(j+0.5)/(double)(m_n_filters));
I'm not sure if using '(i+1)' index instead of 'i' in the DCT formula is correct. I suspect it is a bug. According to Wikipedia (https://en.wikipedia.org/wiki/Discrete_cosine_transform) and Matlab (http://ch.mathworks.com/help/signal/ref/dct.html), DCT-II, which seems to be the targeted implementation here, should have 'i' instead of 'i+1' as an index.
Also, for the normalization (see Ceps.cpp, line 103):
double dct_coeff = m_dct_norm ? (double)sqrt(2./(double)(m_n_filters)) : 1.;
It seems the normalization is not correct either, since if we choose to use it, we should multiply zeros coefficient by 1/sqrt(2). Here is a clear formula and implementation: https://unix4lyfe.org/dct-1d/Pavel KORSHUNOVPavel KORSHUNOVhttps://gitlab.idiap.ch/bob/bob.db.putvein/-/issues/1Is this package private? will it be released to pypi?2017-09-05T14:16:47ZAmir MOHAMMADIIs this package private? will it be released to pypi?https://gitlab.idiap.ch/bob/bob.db.cbsr_nir_vis_2/-/issues/1[driver] You should not use 'enrol', but 'enroll' to address enrollment files2017-10-21T04:56:30ZAndré Anjos[driver] You should not use 'enrol', but 'enroll' to address enrollment filesYou should use 'enroll'. This also states that this package is not properly tested w.r.t. this pointYou should use 'enroll'. This also states that this package is not properly tested w.r.t. this pointTiago de Freitas PereiraTiago de Freitas Pereirahttps://gitlab.idiap.ch/bob/bob.db.cpqd/-/issues/1[driver] The use of 'enrol' is deprecated on the new verification.filelist pa...2017-08-06T16:56:07ZAndré Anjos[driver] The use of 'enrol' is deprecated on the new verification.filelist packageYou should use 'enroll'. This also states that this package is not properly tested w.r.t. this pointYou should use 'enroll'. This also states that this package is not properly tested w.r.t. this pointTiago de Freitas PereiraTiago de Freitas Pereirahttps://gitlab.idiap.ch/bob/bob.pipelines/-/issues/37dask_jobqueue > 0.7.2 changed the API...2021-11-30T18:25:54ZTiago de Freitas Pereiradask_jobqueue > 0.7.2 changed the API..... and this is breaking `SGEIdiapJob`
`**kwargs` was removed from here
https://github.com/dask/dask-jobqueue/blob/0.7.2/dask_jobqueue/core.py#L132.. and this is breaking `SGEIdiapJob`
`**kwargs` was removed from here
https://github.com/dask/dask-jobqueue/blob/0.7.2/dask_jobqueue/core.py#L132Tiago de Freitas PereiraTiago de Freitas Pereirahttps://gitlab.idiap.ch/bob/bob.pipelines/-/issues/33Breakdown samplesets2021-10-29T15:34:56ZTiago de Freitas PereiraBreakdown samplesetsWe should have a function on `bob.pipelines` where it takes as input a `SampleSet` with `N` samples and outputs `N` `SampleSets` with 1 `Sample` each.
ping @hotroshiWe should have a function on `bob.pipelines` where it takes as input a `SampleSet` with `N` samples and outputs `N` `SampleSets` with 1 `Sample` each.
ping @hotroshihttps://gitlab.idiap.ch/bob/bob.bio.base/-/issues/158DIR curve should be updated to PNIR vs. FPIR curve2021-10-29T15:34:57ZManuel Günthersiebenkopf@googlemail.comDIR curve should be updated to PNIR vs. FPIR curveAccording to the new standards, the Detection and Identification Rate curve (DIR) has been renamed by the ISO: https://www.iso.org/obp/ui/fr/#iso:std:iso-iec:19795:-1:ed-2:v1:en
The two axes are now called False Positive Identification R...According to the new standards, the Detection and Identification Rate curve (DIR) has been renamed by the ISO: https://www.iso.org/obp/ui/fr/#iso:std:iso-iec:19795:-1:ed-2:v1:en
The two axes are now called False Positive Identification Rate (FPIR) and False Negative Identification rate (FNIR) = 1- True Positive Identification Rate (TPIR). I do not really know how the curve is now called -- the according part of the ISO document is only available after payment.
So, the first (and easiest) task is to rename the axes to FPIR and TPIR. Second, we should see if our implementation strictly follows the definition (which I believe is the case). Finally, sometimes the curve is plotted with logarithmical y-axis (the x-axis is always log), which only works if we plot FNIR instead of TPIR. It might be good to add both possibilities as flags.https://gitlab.idiap.ch/bob/bob/-/issues/269Bob 10.0.0 release2021-11-04T14:03:50ZTiago de Freitas PereiraBob 10.0.0 releaseWe have had several modifications since the last release. Can we have a new minor release of this one?
We would need to release `bob.bio.base` too (if not the whole bob).
ThanksWe have had several modifications since the last release. Can we have a new minor release of this one?
We would need to release `bob.bio.base` too (if not the whole bob).
Thankshttps://gitlab.idiap.ch/bob/bob.bio.face/-/issues/58New release2021-07-28T15:18:03ZTiago de Freitas PereiraNew releaseWe have had several modifications since the last release. Can we have a new minor release of this one?
We would need to release `bob.bio.base` too (if not the whole bob).
ThanksWe have had several modifications since the last release. Can we have a new minor release of this one?
We would need to release `bob.bio.base` too (if not the whole bob).
Thankshttps://gitlab.idiap.ch/bob/bob.bio.base/-/issues/154BioAlgorithm.score is never used (?)2021-10-29T15:34:56ZLaurent COLBOISBioAlgorithm.score is never used (?)Hi,
I believe that following [this commit](https://gitlab.idiap.ch/bob/bob.bio.base/-/commit/54b3600e337843120e7d36db1cdac9f2e36dfb97), the `BioAlgorithm.score` might never be explicitly called (scoring is always passing through `BioAlg...Hi,
I believe that following [this commit](https://gitlab.idiap.ch/bob/bob.bio.base/-/commit/54b3600e337843120e7d36db1cdac9f2e36dfb97), the `BioAlgorithm.score` might never be explicitly called (scoring is always passing through `BioAlgorithm.score_multiple_biometric_references`). This is unless there is some usage I am not aware of, but I think scoring in `vanilla-biometrics` is always done through `BioAlgorithm.score_samples`, which itself never calls `score`.
This might become confusing for users as the doc only mention the `BioAlgorithm.score` (which moreover is abstract), while the main thing to implement in a `BioAlgorithm` is actually the `BioAlgorithm.score_multiple_biometric_references` (which moreover is not abstract).
ping @amohammadi , this is related to the first question in issue https://gitlab.idiap.ch/bob/bob.bio.base/-/issues/153. But I think it's better that I open a separate issue for clarity.
ping @hotroshi Amir MOHAMMADIAmir MOHAMMADI