beat issueshttps://gitlab.idiap.ch/groups/beat/-/issues2019-10-04T08:44:08Zhttps://gitlab.idiap.ch/beat/beat.core/-/issues/89Improve output error messages2019-10-04T08:44:08ZSamuel GAISTImprove output error messagesWhen not enough data is written on an output, the related cache will be cleaned.
An error message must be shown to the user so he knows what is happening.When not enough data is written on an output, the related cache will be cleaned.
An error message must be shown to the user so he knows what is happening.https://gitlab.idiap.ch/beat/beat.editor/-/issues/182Plotterparameter Editor2019-10-04T15:12:26ZJaden DIEFENBAUGHPlotterparameter Editor[v2] 1 - Edition/Visualization for small editorshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/244Improve plotter new creation handling2019-10-04T15:12:49ZSamuel GAISTImprove plotter new creation handlingSummary
Currently when creating a new Plotter, the prototype contains "plot/unknown/1".
This has problematic implications:
- The editor will fail to load it
- Test will fail because the editor can't load that dataformat
Steps to repr...Summary
Currently when creating a new Plotter, the prototype contains "plot/unknown/1".
This has problematic implications:
- The editor will fail to load it
- Test will fail because the editor can't load that dataformat
Steps to reproduce
1) Click on new
2) Select Plotter
3) Try to edit the plotter created
What is the current bug behavior?
An error is raised and it make the application fail
What is the expected correct behavior?
Either:
- Show a dialog asking to select a dataformat to use.
- Select a suitable dataformat from the prefix. Maybe a simple default like for the algorithm prototype.
Possible fixes
One possibility could be to have a method called after the dialog has been closed that can be re-implemented in sub-classes to do whatever is needed for the newly created object.
Another would be to move the dialog logic in its own method so re-implementing _createNewAsset would be easier.
Note that this affects beat/beat.editor!101[v2] 1 - Edition/Visualization for small editorsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/226When a new/new version of an asset is made, it is not obvious to the user sin...2019-10-04T15:12:51ZZohreh MOSTAANIWhen a new/new version of an asset is made, it is not obvious to the user since it doesn't pop open.At the moment, when you make a new/new version of a asset, it only creates a file in the corresponding directory, but it doesn't actually open the file in the editor, ready to be edited. The user needs to go back through the list of file...At the moment, when you make a new/new version of a asset, it only creates a file in the corresponding directory, but it doesn't actually open the file in the editor, ready to be edited. The user needs to go back through the list of files to find it and open it manually.
This approach not only is not intuitive, but also it can get very confusing very fast especially if you have so many assets with similar names. It is usually the case when you are testing experiments just with minor changes.https://gitlab.idiap.ch/beat/beat.editor/-/issues/242Delete button does not ask for confirmation if you are deleting an asset that...2019-10-04T15:12:53ZZohreh MOSTAANIDelete button does not ask for confirmation if you are deleting an asset that is not being edited at the time.If you are editing an asset and delete the same asset the dialogue box says something like "you are about to delete the asset you are editing currently, are you sure", but if you try to delete another asset while you are still editing an...If you are editing an asset and delete the same asset the dialogue box says something like "you are about to delete the asset you are editing currently, are you sure", but if you try to delete another asset while you are still editing another asset (This is possible because you are able to borrows the files on the left of the editor window), it just deletes the asset without asking any confirmation. This is not good since users can delete some files by accident and there is no way to recover them from the editor at the moment (there is no undo).https://gitlab.idiap.ch/beat/beat.editor/-/issues/234Feature request: Adjusting header view manually2019-10-04T15:12:53ZZohreh MOSTAANIFeature request: Adjusting header view manuallyAt the moment it is not possible to adjust the distance on the header view between Name and Date manually. You can decrease the size of both of them together by bringing the editor/json widget to the left. Even then the first thing that ...At the moment it is not possible to adjust the distance on the header view between Name and Date manually. You can decrease the size of both of them together by bringing the editor/json widget to the left. Even then the first thing that disappears is the name of the folders not the date, and in the extreme case the Name/Date header collapses altogether which is not nice either.
It would be better to be able to adjust the width of Name and Date separately.Samuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/233An empty json file in the wrong directory format crashes the editor2019-10-04T15:12:53ZZohreh MOSTAANIAn empty json file in the wrong directory format crashes the editorIf a user adds an empty json file in the wrong directory structure using file manager or command line like following:
Usually this is the correct structure:
prefix/dataformats/<username>/<dataformatname>/1.json
Lets make a file directly...If a user adds an empty json file in the wrong directory structure using file manager or command line like following:
Usually this is the correct structure:
prefix/dataformats/<username>/<dataformatname>/1.json
Lets make a file directly in <username> folder so we will have:
prefix/dataformats/<username>/1.json
If the editor is already open it shows it in the list of the files without giving any warning to the user. But then if you open this new json file the editor will close and this error is shown in the log:
```
Traceback (most recent call last):
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/widgets/assetwidget.py", line 356, in loadAsset
self.watcher.addPath(self.current_asset.declaration_path)
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/backend/asset.py", line 208, in declaration_path
storage = self.type.storage(self.prefix, self.name)
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/src/beat.backend.python/beat/backend/python/dataformat.py", line 77, in __init__
raise RuntimeError("invalid dataformat name: `%s'" % name)
RuntimeError: invalid dataformat name: `zmostaani/1'
Aborted
```
Now if you try to run the editor again this will be the error:
```
Traceback (most recent call last):
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/widgets/dataformateditor.py", line 601, in <lambda>
lambda: self.dataformat_model.setPrefixPath(self.prefix_path)
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/backend/assetmodel.py", line 182, in setPrefixPath
self.reload()
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/backend/assetmodel.py", line 119, in reload
json_files = _find_json_files(asset_folder)
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/backend/assetmodel.py", line 70, in _find_json_files
asset_items = os.scandir(path)
NotADirectoryError: [Errno 20] Not a directory: '/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.zmostaani.prefix/prefix/dataformats/zmostaani/1.json'
Aborted
```
Even though users are not supposed to make such problematic files but they may by accident and just having log information might not be enough. see #232Samuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/232An empty json file in the correct directory structure crashes the editor2019-10-04T15:12:53ZZohreh MOSTAANIAn empty json file in the correct directory structure crashes the editorAt the moment it is assumed the prefix is completely valid. If a user adds an empty json file (using file manager or command line for example $ touch 1.json) in the correct directory format, if the editor is open it is shown on the list ...At the moment it is assumed the prefix is completely valid. If a user adds an empty json file (using file manager or command line for example $ touch 1.json) in the correct directory format, if the editor is open it is shown on the list of the available asset, without any error or warning. But is you click on it the editor will close completely and there is a log error.
```
Traceback (most recent call last):
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/widgets/assetwidget.py", line 358, in loadAsset
self.__update_content()
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/widgets/assetwidget.py", line 214, in __update_content
editor.load_json(json.loads(json_data))
File "/idiap/user/zmostaani/miniconda3/envs/beat2/lib/python3.6/site-packages/simplejson/__init__.py", line 518, in loads
return _default_decoder.decode(s)
File "/idiap/user/zmostaani/miniconda3/envs/beat2/lib/python3.6/site-packages/simplejson/decoder.py", line 370, in decode
obj, end = self.raw_decode(s)
File "/idiap/user/zmostaani/miniconda3/envs/beat2/lib/python3.6/site-packages/simplejson/decoder.py", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Aborted
```
After the editor crashes you can run it again. It will run containing the mistaken json file. Now assume you know where the problem is and this time you learnt your lesson and you want to use editor to delete the asset. Go to the file in question. Right click on it and choose delete. Again the editor crashes and this is in the log info:
```
Traceback (most recent call last):
File "/remote/idiap.svm/user.active/zmostaani/experiments/beat/beat.editor/beat/editor/widgets/assetwidget.py", line 321, in deleteAsset
if self.current_asset.declaration_path == file_path:
AttributeError: 'NoneType' object has no attribute 'declaration_path'
Aborted
```
You can only remove it now is to use file manager or command line again.
It would be good to handle such instances more gracefully and more informative for the user since it is not easy from this log to understand where the problem is unless the user remembers exactly what they have done to cause this problem. It is not always the case :D
Also if we have multiple instance of editor open from terminal (see #228) and lose this information completely it would be even worse.Samuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/231The cleanup for the content widget is not done properly.2019-10-04T15:12:53ZZohreh MOSTAANIThe cleanup for the content widget is not done properly.The issue is that if you edit an asset (tested with dataformat), and then open another dataformat without saving the previous one the content of what you have opened past will be shown in the one that has not been saved, instead of it be...The issue is that if you edit an asset (tested with dataformat), and then open another dataformat without saving the previous one the content of what you have opened past will be shown in the one that has not been saved, instead of it being in the previous state.
I realize that you don't even need to make a new dataformat. To reproduce the issue, you just need to have several dataformat from one or more than one user available. Start opening them one after another and look at the change in the content!
The issue comes from how the widgets are being cleaned before a new asset is open. The content from previous asset is not cleaned fully and what you see as the newly open asset is not it's own content but information from the leftovers.Samuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/223Remove unused code in protocol template editor2019-10-04T15:12:53ZFlavio TARSETTIRemove unused code in protocol template editorThis targets unused code from the plotter template editorThis targets unused code from the plotter template editorFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/222Database Editor: update naming for set2019-10-04T15:12:53ZFlavio TARSETTIDatabase Editor: update naming for setPatch typo name as possible confusion and collision with python "set" class.
Part of #183Patch typo name as possible confusion and collision with python "set" class.
Part of #183Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/221Open asset related files2019-10-04T15:12:53ZSamuel GAISTOpen asset related filesFiles related to the asset are currently not shown nor editable through beat/beat.editor>.
Add the possibility to edit these using the user's corresponding default editor.Files related to the asset are currently not shown nor editable through beat/beat.editor>.
Add the possibility to edit these using the user's corresponding default editor.[v2] 1 - Edition/Visualization for small editorsSamuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/215Parameter editor for algorithms and plotters editors2019-10-04T15:12:53ZFlavio TARSETTIParameter editor for algorithms and plotters editorsThis issue tracks the progress on the parameter widget reusable component used in algorithms and plotters editorsThis issue tracks the progress on the parameter widget reusable component used in algorithms and plotters editors[v2] 1 - Edition/Visualization for small editorsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/214Documentation contribute.rst for local dependencies and running unit tests ag...2019-10-04T15:12:53ZFlavio TARSETTIDocumentation contribute.rst for local dependencies and running unit tests against themSummary
The documentation does not provide the steps to build local dependencies and run the tests against themSummary
The documentation does not provide the steps to build local dependencies and run the tests against them[v2] 1 - Edition/Visualization for small editorsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/212Generic Spinbox targetting int/uint (8,16,32,64) and float (32,64) numpy types2019-10-04T15:12:53ZFlavio TARSETTIGeneric Spinbox targetting int/uint (8,16,32,64) and float (32,64) numpy typesThis issue tracks the progress on the Generic Spinbox targetting int/uint (8,16,32,64) and float (32,64) numpy typesThis issue tracks the progress on the Generic Spinbox targetting int/uint (8,16,32,64) and float (32,64) numpy typesFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/204[reusable-component] Library Editor2019-10-04T15:12:53ZFlavio TARSETTI[reusable-component] Library EditorA reusable component for library selection is required for various editors.A reusable component for library selection is required for various editors.Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/183Database Editor2019-10-04T15:12:53ZJaden DIEFENBAUGHDatabase Editor[v2] 1 - Edition/Visualization for small editorsSamuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/181Plotter Editor2019-10-04T15:12:53ZJaden DIEFENBAUGHPlotter Editor[v2] 1 - Edition/Visualization for small editorsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/178Library Editor2019-10-04T15:12:53ZJaden DIEFENBAUGHLibrary Editor[v2] 1 - Edition/Visualization for small editorshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/191Remove v1 artifacts2019-10-04T15:12:54ZJaden DIEFENBAUGHRemove v1 artifactsSummary
There are still some artifacts of the v1 editor in v2:
- `.gitignore` has all the Node/JS stuff still in it
- `beat/editor/js` still exists
- `doc/{index.rst,editor.rst,licenses.rst,img/,svg/}` are all still from v1
What does i...Summary
There are still some artifacts of the v1 editor in v2:
- `.gitignore` has all the Node/JS stuff still in it
- `beat/editor/js` still exists
- `doc/{index.rst,editor.rst,licenses.rst,img/,svg/}` are all still from v1
What does it provide?
Remove all of the above:
- Remove all the JS stuff from `.gitignore`
- Remove the `beat/editor/js` directory
- Remove most of the the text in `doc/index.rst` and just have it point to `doc/contribute.rst` for now
- Remove `doc/{editor.rst,licenses.rst}`
- Save `doc/{img/,svg/}` as we'll probably want to adapt these later for v2 documentation