bob.sp issueshttps://gitlab.idiap.ch/bob/bob.sp/-/issues2018-01-24T04:36:49Zhttps://gitlab.idiap.ch/bob/bob.sp/-/issues/2fft implementation is sub-optimal2018-01-24T04:36:49ZAndré Anjosfft implementation is sub-optimal@sbhatta said he has old code that implements a better FFT function. He'll look for it and patch it up.
@pkorshunov as interested party to coordinate and make sure the tests pass afterwards.@sbhatta said he has old code that implements a better FFT function. He'll look for it and patch it up.
@pkorshunov as interested party to coordinate and make sure the tests pass afterwards.Sushil BHATTACHARJEESushil BHATTACHARJEEhttps://gitlab.idiap.ch/bob/bob.sp/-/issues/1bob.sp.Quantization has weird border handling2018-01-24T04:36:49ZAndré Anjosbob.sp.Quantization has weird border handling*Created by: tiagofrepereira2012*
Copying the issue from here (https://github.com/idiap/bob/issues/184)
#####################
By chance, I had a look at the bob.sp.Quantization class. It seems that this class has several issues, esp...*Created by: tiagofrepereira2012*
Copying the issue from here (https://github.com/idiap/bob/issues/184)
#####################
By chance, I had a look at the bob.sp.Quantization class. It seems that this class has several issues, especially in border cases:
1. the call function returns 0 in two cases: when the element is in the first range, or when the element is below the lowest threshold
2. the call function returns the highest index in two cases: when the element is in the last range, or when the element is above the highest threshold
In fact, point (2) cannot even be distinguished in the C++ implementation of the function since the highest threshold in not even stored in the range of thresholds. Usually, when there are 4 ranges, it requires 5 thresholds, but this class holds only 4.Manuel Günthersiebenkopf@googlemail.comManuel Günthersiebenkopf@googlemail.com