bob.pipelines issues
https://gitlab.idiap.ch/bob/bob.pipelines/-/issues
2022-12-06T11:13:39Z
https://gitlab.idiap.ch/bob/bob.pipelines/-/issues/44
check_parameters_for_validity does not always return the same type
2022-12-06T11:13:39Z
Yannick DAYER
check_parameters_for_validity does not always return the same type
Currently, `bob.pipelines.utils.check_parameters_for_validity` can return ["a list or tuple"](https://gitlab.idiap.ch/bob/bob.pipelines/-/blob/master/src/bob/pipelines/utils.py#L117).
This seems weird to return a list **or** a tuple. An...
Currently, `bob.pipelines.utils.check_parameters_for_validity` can return ["a list or tuple"](https://gitlab.idiap.ch/bob/bob.pipelines/-/blob/master/src/bob/pipelines/utils.py#L117).
This seems weird to return a list **or** a tuple. And somewhere down the line, we actually expect a list (with a `remove` method).
Could you ensure that this returns a `list` in all cases (and edit the docstring to reflect that)?
André MAYORAZ
André MAYORAZ
https://gitlab.idiap.ch/bob/bob.pipelines/-/issues/9
SampleSet.insert not accepting DelayedSample objects as item
2020-04-06T06:25:29Z
Yannick DAYER
SampleSet.insert not accepting DelayedSample objects as item
In [`bob/pipelines/sample.py`](https://gitlab.idiap.ch/bob/bob.pipelines/blob/master/bob/pipelines/sample.py#L78), in the `SampleSet` class, the `insert(self, index, item)` does not accept `DelayedSample` objects.
(Because of the test: ...
In [`bob/pipelines/sample.py`](https://gitlab.idiap.ch/bob/bob.pipelines/blob/master/bob/pipelines/sample.py#L78), in the `SampleSet` class, the `insert(self, index, item)` does not accept `DelayedSample` objects.
(Because of the test: `if not isinstance(item, Sample):`.)
To solve:
- either make `DelayedSample` and `Sample` inherit from a `SampleBase` class,
- change the tests in `SampleSet.insert` to accept the base class an thus all Sample-like classes;
or:
- change the tests in `SampleSet.insert` to accept both `Sample` and `DelayedSample`.
(Could be the same with `__setitem__`.)
Tiago de Freitas Pereira
Tiago de Freitas Pereira