diff --git a/src/bob/pipelines/utils.py b/src/bob/pipelines/utils.py index 97367d8f519c61475642a8b9f0ca51c4fd0b4f9d..3275d5c56c399ac5566ded815ffbdd154d2bd876 100644 --- a/src/bob/pipelines/utils.py +++ b/src/bob/pipelines/utils.py @@ -86,7 +86,7 @@ def check_parameters_for_validity( """Checks the given parameters for validity. Checks a given parameter is in the set of valid parameters. It also - assures that the parameters form a tuple or a list. If parameters is + assures that the returned parameters form a list. If parameters is 'None' or empty, the default_parameters will be returned (if default_parameters is omitted, all valid_parameters are returned). diff --git a/tests/test_utils.py b/tests/test_utils.py index 48ac1f7a1dce0120d74fe16271d98d5f1935f06d..488c796cb3998a3ff59714dc0dcb3f1494cfe91d 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -235,6 +235,15 @@ def test_check_parameters_validity(): == f"Invalid {desc_str} '{param[1]}'. Valid values are {valid_values}, or lists/tuples of those" ) + # Empty default parameter + param = None + default = None + retval = check_parameters_for_validity( + param, desc_str, valid_values, default + ) + assert type(retval) is list + assert retval == valid_values + # Invalid default parameter param = None default = "false"