Improvement suggestions
Work in this package looks great! Congrats.
Here are some tips to make it even better:
- Please add our "Bob" citations to your README file, since your work is completely based on it
- Ask the user to install "miniconda" instead of "conda"
- In
setup.py
, please remove my name off the header. Actually, remove the whole header, we don't need it. Just leave the first two lines. - In your
requirements.txt
, remove all indirect dependencies, use only stuff you directly depend on - Your package structure will be cleaner if you remove the
code
subdirectory inbob.paper.isba2018_entropy
. Just put the contents of the package on the root of the package for clarity - Your
buildout.cfg
does not needmr.developer
, or any other associated settings. Make it as clean as our stock template https://gitlab.idiap.ch/bob/bob.admin/blob/master/templates/simple-buildout.cfg - A suggestion: why don't you suggest
pip install bob.paper.isba2018_entropy
instead of using bothgit
andbuildout
? Isn't that easier? That also reduces the amount of dependencies the final user environment needs.