Work in this package looks great! Congrats.
Here are some tips to make it even better:
- Please add our "Bob" citations to your README file, since your work is completely based on it
- Ask the user to install "miniconda" instead of "conda"
setup.py, please remove my name off the header. Actually, remove the whole header, we don't need it. Just leave the first two lines.
- In your
requirements.txt, remove all indirect dependencies, use only stuff you directly depend on
- Your package structure will be cleaner if you remove the
bob.paper.isba2018_entropy. Just put the contents of the package on the root of the package for clarity
buildout.cfgdoes not need
mr.developer, or any other associated settings. Make it as clean as our stock template https://gitlab.idiap.ch/bob/bob.admin/blob/master/templates/simple-buildout.cfg
- A suggestion: why don't you suggest
pip install bob.paper.isba2018_entropyinstead of using both
buildout? Isn't that easier? That also reduces the amount of dependencies the final user environment needs.