Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.paper.isba2018_entropy bob.paper.isba2018_entropy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.paper.isba2018_entropybob.paper.isba2018_entropy
  • Issues
  • #1
Closed
Open
Issue created Oct 17, 2017 by André Anjos@andre.anjos💬Owner

Improvement suggestions

Work in this package looks great! Congrats.

Here are some tips to make it even better:

  1. Please add our "Bob" citations to your README file, since your work is completely based on it
  2. Ask the user to install "miniconda" instead of "conda"
  3. In setup.py, please remove my name off the header. Actually, remove the whole header, we don't need it. Just leave the first two lines.
  4. In your requirements.txt, remove all indirect dependencies, use only stuff you directly depend on
  5. Your package structure will be cleaner if you remove the code subdirectory in bob.paper.isba2018_entropy. Just put the contents of the package on the root of the package for clarity
  6. Your buildout.cfg does not need mr.developer, or any other associated settings. Make it as clean as our stock template https://gitlab.idiap.ch/bob/bob.admin/blob/master/templates/simple-buildout.cfg
  7. A suggestion: why don't you suggest pip install bob.paper.isba2018_entropy instead of using both git and buildout? Isn't that easier? That also reduces the amount of dependencies the final user environment needs.
Edited Oct 17, 2017 by Vedrana KRIVOKUCA
Assignee
Assign to
Time tracking