From 60cd1d4cbe04872fb129e4f426ca8fa5c52f92c0 Mon Sep 17 00:00:00 2001
From: Manuel Gunther <siebenkopf@googlemail.com>
Date: Mon, 25 Apr 2016 13:56:52 -0600
Subject: [PATCH] Corrected implementation of open set recognition rate tests
 (which are failing)

Conflicts:
	bob/measure/test_error.py
---
 bob/measure/test_error.py | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/bob/measure/test_error.py b/bob/measure/test_error.py
index 0764642..70060f8 100644
--- a/bob/measure/test_error.py
+++ b/bob/measure/test_error.py
@@ -330,26 +330,26 @@ def test_open_set_recognition_rate():
 
   far_value = 0.01
 
-  #No error files
+  # No error files
   cmc_scores = bob.measure.load.cmc_four_column(F("scores-cmc-4col-open-set.txt"))
   normal_scores = bob.measure.load.split_four_column(F("scores-cmc-4col-open-set.txt"))
-  assert bob.measure.recognition_rate(cmc_scores), 1.0
-  assert bob.measure.recognition_rate(cmc_scores, threshold=0.5), 1.0
+  assert abs(bob.measure.recognition_rate(cmc_scores) - 1.0) < 1e-8
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=0.5) - 1.0) < 1e-8
   t = bob.measure.far_threshold(normal_scores[0], normal_scores[1],far_value)
-  assert bob.measure.recognition_rate(cmc_scores, threshold=t), 1.0
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=t) - 1.0) < 1e-8
 
-  #One error
+  # One error
   cmc_scores = bob.measure.load.cmc_four_column(F("scores-cmc-4col-open-set.txt"))
   normal_scores = bob.measure.load.split_four_column(F("scores-cmc-4col-open-set.txt"))
-  assert bob.measure.recognition_rate(cmc_scores), 0.857142857143
-  assert bob.measure.recognition_rate(cmc_scores, threshold=0.5), 0.857142857143
+  assert abs(bob.measure.recognition_rate(cmc_scores) - 0.857142857143) < 1e-8
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=0.5) - 0.857142857143) < 1e-8
   t = bob.measure.far_threshold(normal_scores[0], normal_scores[1],far_value)
-  assert bob.measure.recognition_rate(cmc_scores, threshold=t), 0.857142857143
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=t) - 0.857142857143) < 1e-8
 
-  #Two errors
+  # Two errors
   cmc_scores = bob.measure.load.cmc_four_column(F("scores-cmc-4col-open-set.txt"))
   normal_scores = bob.measure.load.split_four_column(F("scores-cmc-4col-open-set.txt"))
-  assert bob.measure.recognition_rate(cmc_scores), 0.857142857143
-  assert bob.measure.recognition_rate(cmc_scores, threshold=0.5), 0.857142857143
+  assert abs(bob.measure.recognition_rate(cmc_scores) - 0.857142857143) < 1e-8
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=0.5) - 0.857142857143) < 1e-8
   t = bob.measure.far_threshold(normal_scores[0], normal_scores[1],far_value)
-  assert bob.measure.recognition_rate(cmc_scores, threshold=t), 0.0
+  assert abs(bob.measure.recognition_rate(cmc_scores, threshold=t)) < 1e-8
-- 
GitLab