From 6e6addeabad630ef33af198e9b883738b056ca19 Mon Sep 17 00:00:00 2001
From: Amir MOHAMMADI <amir.mohammadi@idiap.ch>
Date: Fri, 7 Feb 2020 15:22:12 +0100
Subject: [PATCH] nitpick
---
bob/learn/tensorflow/loss/BaseLoss.py | 2 +-
bob/learn/tensorflow/loss/ContrastiveLoss.py | 4 +---
bob/learn/tensorflow/loss/StyleLoss.py | 2 +-
bob/learn/tensorflow/loss/TripletLoss.py | 2 +-
bob/learn/tensorflow/loss/mmd.py | 5 +++++
5 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/bob/learn/tensorflow/loss/BaseLoss.py b/bob/learn/tensorflow/loss/BaseLoss.py
index 5b30e18e..50e83e14 100644
--- a/bob/learn/tensorflow/loss/BaseLoss.py
+++ b/bob/learn/tensorflow/loss/BaseLoss.py
@@ -4,7 +4,7 @@
import logging
import tensorflow as tf
-logger = logging.getLogger("bob.learn.tensorflow")
+logger = logging.getLogger(__name__)
slim = tf.contrib.slim
diff --git a/bob/learn/tensorflow/loss/ContrastiveLoss.py b/bob/learn/tensorflow/loss/ContrastiveLoss.py
index 93612cbf..6fa29f1a 100644
--- a/bob/learn/tensorflow/loss/ContrastiveLoss.py
+++ b/bob/learn/tensorflow/loss/ContrastiveLoss.py
@@ -4,9 +4,7 @@
import logging
import tensorflow as tf
-from bob.learn.tensorflow.utils import (
- compute_euclidean_distance,
-)
+from bob.learn.tensorflow.utils import compute_euclidean_distance
logger = logging.getLogger(__name__)
diff --git a/bob/learn/tensorflow/loss/StyleLoss.py b/bob/learn/tensorflow/loss/StyleLoss.py
index 36b53b66..43cc655e 100644
--- a/bob/learn/tensorflow/loss/StyleLoss.py
+++ b/bob/learn/tensorflow/loss/StyleLoss.py
@@ -5,7 +5,7 @@
import logging
import tensorflow as tf
import functools
-logger = logging.getLogger("bob.learn.tensorflow")
+logger = logging.getLogger(__name__)
def content_loss(noises, content_features):
diff --git a/bob/learn/tensorflow/loss/TripletLoss.py b/bob/learn/tensorflow/loss/TripletLoss.py
index 2d487cc5..d2616d6a 100644
--- a/bob/learn/tensorflow/loss/TripletLoss.py
+++ b/bob/learn/tensorflow/loss/TripletLoss.py
@@ -3,7 +3,7 @@
# @author: Tiago de Freitas Pereira <tiago.pereira@idiap.ch>
import logging
-logger = logging.getLogger("bob.learn.tensorflow")
+logger = logging.getLogger(__name__)
import tensorflow as tf
from bob.learn.tensorflow.utils import compute_euclidean_distance
diff --git a/bob/learn/tensorflow/loss/mmd.py b/bob/learn/tensorflow/loss/mmd.py
index bd7df3e5..2933d7b1 100644
--- a/bob/learn/tensorflow/loss/mmd.py
+++ b/bob/learn/tensorflow/loss/mmd.py
@@ -2,6 +2,8 @@ import tensorflow as tf
def compute_kernel(x, y):
+ """Gaussian kernel.
+ """
x_size = tf.shape(x)[0]
y_size = tf.shape(y)[0]
dim = tf.shape(x)[1]
@@ -17,6 +19,9 @@ def compute_kernel(x, y):
def mmd(x, y):
+ """Maximum Mean Discrepancy with Gaussian kernel.
+ See: https://stats.stackexchange.com/a/276618/49433
+ """
x_kernel = compute_kernel(x, x)
y_kernel = compute_kernel(y, y)
xy_kernel = compute_kernel(x, y)
--
GitLab