bob.ip.stereo merge requestshttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests2021-01-25T11:11:13Zhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/9opencv bob conv2021-01-25T11:11:13ZDavid GEISSBUHLERopencv bob convDavid GEISSBUHLERDavid GEISSBUHLERhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/11Implement unit test for image format conversion2021-01-25T11:18:12ZVincent POLLETImplement unit test for image format conversionImplement unit test for image format conversionImplement unit test for image format conversionVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/1Api fix2021-10-29T15:34:59ZAnjith GEORGEanjith.george@idiap.chApi fixAnjith GEORGEanjith.george@idiap.chAnjith GEORGEanjith.george@idiap.chhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/3Revert "[CI] debuging: use c++14 to avoid clang error" -- compile options are...2021-10-29T15:34:59ZVincent POLLETRevert "[CI] debuging: use c++14 to avoid clang error" -- compile options are ignored by conda buildThis reverts commit 9f5f0ba89de717c6dbf0363a87e135f84836061dThis reverts commit 9f5f0ba89de717c6dbf0363a87e135f84836061dVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/2Unit test and pipeline debuging2021-10-29T15:34:59ZVincent POLLETUnit test and pipeline debugingHi David,
I am working on the unit test, but there are a few things I am not sure about. I thought we could have the discussion here, but let me know if it is not appropriate.
First thing, I am not sure I understand how the reproj...Hi David,
I am working on the unit test, but there are a few things I am not sure about. I thought we could have the discussion here, but let me know if it is not appropriate.
First thing, I am not sure I understand how the reproject_image function works.
```python
projected_image = reproject_image(groundtruth, map_3d, color, camera_pair)
```
Here I was trying to project an image of the color camera onto the same camera, expecting that it would be an identity operation. However the output is different from the input image, it is shifted up right. Is it normal or am I understanding it wrong ? In order to project the image from the nir_left camera onto the color, would this work ?
```python
projected_image = reproject_image(left_image, map_3d, color, camera_pair)
```
Second thing, what would be the best metric to measure if the generated output is close enough to the input ? Similarity measure from bob.ip.qualitymeasure looked promising, but is it enough ? What do you think ?
Thank you,
VincentDavid GEISSBUHLERDavid GEISSBUHLERhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/4Improvements2021-10-29T15:34:59ZVincent POLLETImprovementsImprovements over previous algorithm implementations and CI/CD debuggingImprovements over previous algorithm implementations and CI/CD debuggingDavid GEISSBUHLERDavid GEISSBUHLERhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/5[cleaning] removed old defaults2021-10-29T15:35:00ZDavid GEISSBUHLER[cleaning] removed old defaultshttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/6Resolve "In painting has different output based on computer OS"2021-10-29T15:35:00ZVincent POLLETResolve "In painting has different output based on computer OS"Closes #2
As discussed in #2, small differences coming from difference linear algebra libraries can be amplified during further computation (especially in uint8 precision) and lead to slightly different output on different systems. T...Closes #2
As discussed in #2, small differences coming from difference linear algebra libraries can be amplified during further computation (especially in uint8 precision) and lead to slightly different output on different systems. This is not something that can be easily worked around, therefore the chosen solution is to increase the tolerance of the unit tests to allow for these small modifications. https://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/7Landmarks bbox unit test2021-10-29T15:35:00ZVincent POLLETLandmarks bbox unit testImplements unit test for projection of landmarks and bounding box on images.Implements unit test for projection of landmarks and bounding box on images.Vincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/8Resolve "Wrong speckleWindowSize value"2021-10-29T15:35:00ZVincent POLLETResolve "Wrong speckleWindowSize value"Closes #3
Fix speckleWindowSize valueCloses #3
Fix speckleWindowSize valueDavid GEISSBUHLERDavid GEISSBUHLERhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/10Opencv bob conv2021-10-29T15:35:00ZDavid GEISSBUHLEROpencv bob convDavid GEISSBUHLERDavid GEISSBUHLERhttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/12Doc2021-10-29T15:35:00ZVincent POLLETDocSmall fixes in documentationSmall fixes in documentationVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/13Remove image format conversion functions already implemented in bob.io.image....2021-10-29T15:35:00ZVincent POLLETRemove image format conversion functions already implemented in bob.io.image.utilsRemove image format conversion functions already implemented in bob.io.image.utilsRemove image format conversion functions already implemented in bob.io.image.utilsVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/14Updates for bob's 8.02021-10-29T15:35:00ZVincent POLLETUpdates for bob's 8.0- Opencv package from the `defaults` conda channel has a dependency on `hdf5.1.10.2` which conflicts with bob's (`1.10.6`). Therefore opencv is build in `bob/conda` and we use this package. New opencv version is 4.5.0 (previously was 3.4...- Opencv package from the `defaults` conda channel has a dependency on `hdf5.1.10.2` which conflicts with bob's (`1.10.6`). Therefore opencv is build in `bob/conda` and we use this package. New opencv version is 4.5.0 (previously was 3.4.2)
- Updates in documentation config for new sphinx version.
- clean-up of dependencies in `conda/meta.yaml` and `requirements.txt`.
- Due to a faulty packaging in the opencv package, it is not found by pkg_resources and we can't have it in `requirements.txt`. **Therefore `bob.ip.stereo` is now NOT pip-installable**, however conda-based install still work.Vincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/15Add bob.io.stream.filters for stereo operations2021-10-29T15:35:00ZVincent POLLETAdd bob.io.stream.filters for stereo operationsImplements StreamFilters for stereo operations: warp, stereo and projection
This used to be a part of bob.io.stream.
In order to use cameras associated with Streams, the Stream and StreamFile classes of bob.io.stream are modified when ...Implements StreamFilters for stereo operations: warp, stereo and projection
This used to be a part of bob.io.stream.
In order to use cameras associated with Streams, the Stream and StreamFile classes of bob.io.stream are modified when this module is imported.Vincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/16Add pyproject.toml to comply with pip standard2021-10-29T15:35:00ZVincent POLLETAdd pyproject.toml to comply with pip standardVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/17Warp calibration2021-10-29T15:35:00ZVincent POLLETWarp calibrationScript to perform "linear" calibration: recording markers in each stream to use the warp transform.Script to perform "linear" calibration: recording markers in each stream to use the warp transform.Vincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/18Doc calib2021-10-29T15:35:00ZVincent POLLETDoc calibDocumentation and cleaning of calibration script, high level documentation for calibration procedureDocumentation and cleaning of calibration script, high level documentation for calibration procedureVincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/19Calibration2021-10-29T15:35:00ZVincent POLLETCalibrationCalibration scripts to estimate camera parameters used in stereo processing.Calibration scripts to estimate camera parameters used in stereo processing.Vincent POLLETVincent POLLEThttps://gitlab.idiap.ch/bob/bob.ip.stereo/-/merge_requests/20Add mesa-libGL as yum requirements for test phase in CI2021-10-29T15:35:00ZVincent POLLETAdd mesa-libGL as yum requirements for test phase in CIVincent POLLETVincent POLLET