diff --git a/bob/ip/flandmark/main.cpp b/bob/ip/flandmark/main.cpp index 9ae20061fbe1d336943e4495223c6ff289bc1090..9a18a8049833a27c0fabd42851bb5a8b0db215f0 100644 --- a/bob/ip/flandmark/main.cpp +++ b/bob/ip/flandmark/main.cpp @@ -68,23 +68,25 @@ static PyObject* create_module (void) { if (PyType_Ready(&PyBobIpFlandmark_Type) < 0) return 0; # if PY_VERSION_HEX >= 0x03000000 - PyObject* m = PyModule_Create(&module_definition); + PyObject* module = PyModule_Create(&module_definition); + auto module_ = make_xsafe(module); + const char* ret = "O"; # else - PyObject* m = Py_InitModule3(BOB_EXT_MODULE_NAME, module_methods, module_docstr); + PyObject* module = Py_InitModule3(BOB_EXT_MODULE_NAME, module_methods, module_docstr); + const char* ret = "N"; # endif - if (!m) return 0; - auto m_ = make_safe(m); ///< protects against early returns + if (!module) return 0; /* register the types to python */ Py_INCREF(&PyBobIpFlandmark_Type); - if (PyModule_AddObject(m, "Flandmark", (PyObject *)&PyBobIpFlandmark_Type) < 0) return 0; + if (PyModule_AddObject(module, "Flandmark", (PyObject *)&PyBobIpFlandmark_Type) < 0) return 0; /* imports dependencies */ if (import_bob_blitz() < 0) return 0; if (import_bob_core_logging() < 0) return 0; if (import_bob_io_base() < 0) return 0; - return Py_BuildValue("O", m); + return Py_BuildValue(ret, module); } PyMODINIT_FUNC BOB_EXT_ENTRY_NAME (void) { diff --git a/bob/ip/flandmark/version.cpp b/bob/ip/flandmark/version.cpp index 3374623eee3948b5da87c6652bc83cede1530e9e..d8b969f19e0dab7fef8d089d3df9c963a8ba915f 100644 --- a/bob/ip/flandmark/version.cpp +++ b/bob/ip/flandmark/version.cpp @@ -57,21 +57,23 @@ static PyModuleDef module_definition = { static PyObject* create_module (void) { # if PY_VERSION_HEX >= 0x03000000 - PyObject* m = PyModule_Create(&module_definition); + PyObject* module = PyModule_Create(&module_definition); + auto module_ = make_xsafe(module); + const char* ret = "O"; # else - PyObject* m = Py_InitModule3(BOB_EXT_MODULE_NAME, module_methods, module_docstr); + PyObject* module = Py_InitModule3(BOB_EXT_MODULE_NAME, module_methods, module_docstr); + const char* ret = "N"; # endif - if (!m) return 0; - auto m_ = make_safe(m); ///< protects against early returns + if (!module) return 0; /* register version numbers and constants */ - if (PyModule_AddStringConstant(m, "module", BOB_EXT_MODULE_VERSION) < 0) return 0; + if (PyModule_AddStringConstant(module, "module", BOB_EXT_MODULE_VERSION) < 0) return 0; PyObject* externals = build_version_dictionary(); if (!externals) return 0; - if (PyModule_AddObject(m, "externals", externals) < 0) return 0; + if (PyModule_AddObject(module, "externals", externals) < 0) return 0; - return Py_BuildValue("O", m); + return Py_BuildValue(ret, module); } PyMODINIT_FUNC BOB_EXT_ENTRY_NAME (void) {