bob.extension issueshttps://gitlab.idiap.ch/bob/bob.extension/-/issues2017-08-11T22:23:17Zhttps://gitlab.idiap.ch/bob/bob.extension/-/issues/34cflags_other is never used when compiling extensions2017-08-11T22:23:17ZAmir MOHAMMADIcflags_other is never used when compiling extensionsThis is related to exporting the `--pthread` in the `CFLAGS` variable to make sure we can compile against `blitz`.
but a look at:
```sh
$ pkg-config --cflags-only-other blitz
-pthread
```
revealed that `bob.extension` is ignoring this f...This is related to exporting the `--pthread` in the `CFLAGS` variable to make sure we can compile against `blitz`.
but a look at:
```sh
$ pkg-config --cflags-only-other blitz
-pthread
```
revealed that `bob.extension` is ignoring this flag. Even though such method exists: https://www.idiap.ch/software/bob/docs/latest/bob/bob.extension/master/py_api.html#bob.extension.pkgconfig.cflags_other but it was never used.
A quick and dirty patch (see below) fixes the problem but I'll leave that to you @andre.anjos to implement this properly.
```diff
diff --git a/bob/extension/__init__.py b/bob/extension/__init__.py
index ed11362..593f599 100644
--- a/bob/extension/__init__.py
+++ b/bob/extension/__init__.py
@@ -408,6 +408,7 @@ class Extension(DistutilsExtension):
self.pkg_libraries += libs
parameters['extra_link_args'] += pkg.other_libraries()
+ parameters['extra_compile_args'].extend(pkg.cflags_other().get('extra_compile_args', []))
# add the -isystem to all system include dirs
for k in system_includes:
```Refactoring 2016 and gitlab migration milestoneAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/bob/bob.extension/-/issues/29Please make the bob.examples uptodate2017-08-11T22:23:18ZAmir MOHAMMADIPlease make the bob.examples uptodate* [x] should go through migration guide
* [x] update to new doc style both in Python and cpp
* [x] explain how to write documentation properly with examples and guides
* [x] should go through migration guide
* [x] update to new doc style both in Python and cpp
* [x] explain how to write documentation properly with examples and guides
Refactoring 2016 and gitlab migration milestoneAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/bob/bob.extension/-/issues/23NameError: global name 'BRANCH_RE' is not defined2017-08-11T22:23:18ZAmir MOHAMMADINameError: global name 'BRANCH_RE' is not defined```
======================================================================
ERROR: bob.extension.test_scripts.test_new_version
----------------------------------------------------------------------
Traceback (most recent call last):
...```
======================================================================
ERROR: bob.extension.test_scripts.test_new_version
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/amir/miniconda/envs/bob-2.3.4-2.7/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/amir/idiap/git/bobs/bob.extension/bob/extension/test_scripts.py", line 28, in test_new_version
new_version(['--dry-run', '--stable-version', '20.7.0', '--latest-version', '20.8.0'])
File "/home/amir/idiap/git/bobs/bob.extension/bob/extension/scripts/new_version.py", line 210, in main
_update_readme(args.stable_version)
File "/home/amir/idiap/git/bobs/bob.extension/bob/extension/scripts/new_version.py", line 90, in _update_readme
if BRANCH_RE.search(line) is not None and "gitlab" in line:
NameError: global name 'BRANCH_RE' is not defined
```
I don't know why this does not happen in nightlies but I see this error in my PC.Refactoring 2016 and gitlab migration milestoneAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/bob/bob.extension/-/issues/22Link on latest-docs for all READMEs are wrong2017-08-11T22:23:18ZAndré AnjosLink on latest-docs for all READMEs are wrongShould change ``bioidiap`` -> ``bob``, as soon as nightlies are ready.Should change ``bioidiap`` -> ``bob``, as soon as nightlies are ready.Refactoring 2016 and gitlab migration milestonehttps://gitlab.idiap.ch/bob/bob.extension/-/issues/21Naming conventions for BOB_DOCUMENTATION_SERVER, DOCUSER, DOCPASS and DOCSERVER2017-08-11T22:23:18ZAndré AnjosNaming conventions for BOB_DOCUMENTATION_SERVER, DOCUSER, DOCPASS and DOCSERVERIt would be good to standardise this accross our build and extension system. In some cases, BOB_DOCUMENTATION_SERVER is used, in some other DOCSERVER. The variables for the user and password don't have any `BOB_` prefix.It would be good to standardise this accross our build and extension system. In some cases, BOB_DOCUMENTATION_SERVER is used, in some other DOCSERVER. The variables for the user and password don't have any `BOB_` prefix.Refactoring 2016 and gitlab migration milestonehttps://gitlab.idiap.ch/bob/bob.extension/-/issues/20CMake-based library building does not take BOB_PREFIX_PATH with priority2017-08-11T22:23:18ZAndré AnjosCMake-based library building does not take BOB_PREFIX_PATH with priorityThis one is hard to reproduce. You basically need to have two environments with pre-compiled binaries (which is easy to obtain with conda create --clone btw) to reproduce the issue. This example is a bit contrived, but shows the problem:...This one is hard to reproduce. You basically need to have two environments with pre-compiled binaries (which is easy to obtain with conda create --clone btw) to reproduce the issue. This example is a bit contrived, but shows the problem:
- /path/to/env/1
- /path/to/env/2
Suppose, for instance, `env/1` is a clone of `env/2`. The python distribution is taken from `env/1` where all externals are installed. Now I set `BOB_PREFIX_PATH` to `env/2`. I'd then expect all libraries produced by the build will be linked against the copies in `env/2`.
This happens OK for the libraries produced through Python, since our file finding utils (in `bob.extension.utils`) will do their magic, but that is not happening for CMake-based libraries (all `libbob_xyz.so`). Is there a way to make it happen?Refactoring 2016 and gitlab migration milestone