From 631bbc4c44f0cebf7d46b1f33e88c110fdd2bdf8 Mon Sep 17 00:00:00 2001
From: Andre Anjos <andre.dos.anjos@gmail.com>
Date: Mon, 7 Jan 2019 17:27:19 +0100
Subject: [PATCH] [scripts][changelog] Fix minor code issues
---
bob/devtools/scripts/changelog.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bob/devtools/scripts/changelog.py b/bob/devtools/scripts/changelog.py
index 4a7f392c..af80b7a7 100644
--- a/bob/devtools/scripts/changelog.py
+++ b/bob/devtools/scripts/changelog.py
@@ -91,8 +91,8 @@ def changelog(target, changelog, group, mode, since):
# reads package list or considers name to be a package name
if os.path.exists(target) and os.path.isfile(target):
bdt.logger.info('Reading package names from file %s...', target)
- with open(target, 'rb') as f:
- packages = [k.strip() for k in f.readlines() if k and not \
+ with open(target, 'rt') as f:
+ packages = [k.strip() for k in f.readlines() if k.strip() and not \
k.strip().startswith('#')]
else:
bdt.logger.info('Assuming %s is a package name (file does not ' \
@@ -106,7 +106,7 @@ def changelog(target, changelog, group, mode, since):
for package in packages:
if '/' not in package:
- package = '/'.join(group, package)
+ package = '/'.join((group, package))
# retrieves the gitlab package object
use_package = gl.projects.get(package)
--
GitLab