Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
bob.db.base
bob.db.base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • bob
  • bob.db.basebob.db.base
  • Issues
  • #22

Closed
Open
Opened Nov 27, 2017 by Amir MOHAMMADI@amohammadi
  • Report abuse
  • New issue
Report abuse New issue

Loading data from databases with minimal parameters provided

As of now it seems that we do not have a single way to load a sample in our databases.

The old db's load like this:

db = Database(original_directory='/some/path')
sample = db.objects()[0]
data = sample.load(db.original_directory, db.original_extension)

The current guide advices this:

db = Database(original_directory='/some/path')
sample = db.objects()[0]
data = sample.load()

but this requires changes in all db interfaces because it suggests that each db sample object will carry a reference to original_directory.

I suggest we do like this:

db = Database(original_directory='/some/path')
sample = db.objects()[0]
data = db.load(sample)

This is similar in how annotations are returned in high-level interfaces and hides away the fact that the database is a file-based one.

It can be easily implemented for all current databases that we have like this:

class bob.db.base.Database:
  def load(self, file):
    return file.load(self.original_directory, self.original_extension)

What do you think?

Edited Nov 27, 2017 by Amir MOHAMMADI
Assignee
Assign to
Bob 9.0.0
Milestone
Bob 9.0.0
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: bob/bob.db.base#22