Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
bob.db.base
bob.db.base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • bob
  • bob.db.basebob.db.base
  • Issues
  • #13

Closed
Open
Opened Apr 20, 2017 by Manuel Günther@mguenther
  • Report abuse
  • New issue
Report abuse New issue

The Database interface lacks a constructor

The current Database interface contains a function original_file_names, which accesses the self.original_directory and self.original_extension parameters: https://gitlab.idiap.ch/bob/bob.db.base/blob/master/bob/db/base/database.py#L147. In the old bob.db.verification.utils.Database, these parameters were passes in the constructor, but here, there is no way to set these parameters, as the Database class does not have a constructor.

In several derived classes (for example, bob.db.mobio: https://gitlab.idiap.ch/bob/bob.db.mobio/blob/master/bob/db/mobio/query.py#L40), these parameters are passed in the constructor, but as the base class does not accept them anymore as parameters, they are not used at all, see bob.db.mobio#7

I remember that we have discussed this issue during the database refactoring. I don't remember, what was the outcome of this discussion. Shall the low-level databases be able to retrieve the original data, e.g., using the original_file_names function (in which case we need to provide original_directory and original_extension as parameters to the constructor), or shall we remove this function?

Assignee
Assign to
May 2017 Hackathon
Milestone
May 2017 Hackathon
Assign milestone
Time tracking
None
Due date
None
1
Labels
Important
Assign labels
  • View project labels
Reference: bob/bob.db.base#13