Databases should make sure their load method is properly working
Following this issue: #29 (closed) The databases are loading their own data from now on which uses bob.db.base.File.load which uses bob.io.base.load but since databases are mostly image and audio databases an import of bob.io.image or bob.io.audio is needed in the databases.
- bob.db.voxforge
ping @bob
Activity
The
load()method of the Files for each individual database should be tested, with a test skip in case the database files are not available on the test machine. You can see how to do this in this example: https://gitlab.idiap.ch/bob/bob.db.verafinger/blob/master/bob/db/verafinger/test.pyIf you do this and test before pushing (at Idiap at least), you'll see you miss an import as the load will fail.
@akomaty you need to write
import bob.io.audiohere:https://gitlab.idiap.ch/bob/bob.db.voxforge/blob/master/bob/db/voxforge/__init__.py#L27Edited by Amir MOHAMMADI-
@akomaty @tiago.pereira following our change to
bob.bio.baseto use the databases's load method. Now virtually all databases use this method to load the files: https://gitlab.idiap.ch/bob/bob.db.base/blob/master/bob/db/base/file.py#L110 while files were being read like this before: https://gitlab.idiap.ch/bob/bob.bio.spear/blob/master/bob/bio/spear/preprocessor/Base.py#L17You need to override that method and return properly.
I agree with Amir. I think the import of
bob.io.audioshould be in the files, where it is actually used, i.e., in ``bob.bio.spear`: https://gitlab.idiap.ch/bob/bob.bio.spear/blob/master/bob/bio/spear/preprocessor/Base.py#L3
