Commit 82ae4eef authored by Amir MOHAMMADI's avatar Amir MOHAMMADI
Browse files

Remove explicit shutdown of dask clients in commands

parent f2dee741
Pipeline #44904 failed with stage
in 1 minute and 54 seconds
......@@ -193,8 +193,3 @@ def vanilla_biometrics(
)"Experiment finished !!!!!")
if dask_client is not None:"Shutdown workers !!!!!")
dask_client.shutdown()"Done !!!!!")
......@@ -331,7 +331,3 @@ def vanilla_biometrics_ztnorm(
_ = compute_scores(zt_normed_scores, dask_client)"Experiment finished !!!!!")
Please register or sign in to reply
if dask_client is not None:"Shutdown workers !!!!!")
  • Hi @amohammadi,

    Why that? We should shutdown the client while using the CLI command.

  • dask already does this as part of their clean up.

  • It's just a good practice to clean up your stuff. You can have an exception in between and those workers can be opened for a while. It's better to leave this shutdown there.

  • I don't see any try and catch here. Anyway from what I have seen, as soon as the server crashes, dask clients automatically exit. This has been almost instant in my experience.

Please register or sign in to reply"Done !!!!!")
\ No newline at end of file
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment