Remove explicit shutdown of dask clients in commands

bob/bio/base/script/vanilla_biometrics.py

@@ -51,7 +51,7 @@ It is possible to do it via configuration file
    >>> database = .... # Biometric Database connector (class that implements the methods: `background_model_samples`, `references` and `probes`)"
 
 \b
-  
+
 
 """
 
@@ -193,8 +193,3 @@ def vanilla_biometrics(
     )
 
     logger.info("Experiment finished !!!!!")
-    if dask_client is not None:
-        logger.info("Shutdown workers !!!!!")
-        dask_client.shutdown()
-        logger.info("Done !!!!!")
-

bob/bio/base/script/vanilla_biometrics_ztnorm.py

@@ -47,7 +47,7 @@ $ bob pipelines vanilla-biometrics DATABASE PIPELINE -vv
  Check out all PIPELINE available by running:
   `resource.py --types pipeline`
 \b
-  
+
   and all available databases by running:
   `resource.py --types database`
 
@@ -66,7 +66,7 @@ It is possible to do it via configuration file
    >>> database = .... # Biometric Database connector (class that implements the methods: `background_model_samples`, `references` and `probes`)"
 
 \b
-  
+
 
 """
 
@@ -292,7 +292,7 @@ def vanilla_biometrics_ztnorm(
         def _build_filename(score_file_name, suffix):
             return os.path.join(score_file_name, suffix)
 
-        # Running RAW_SCORES        
+        # Running RAW_SCORES
         raw_scores = post_process_scores(
             pipeline, raw_scores, _build_filename(score_file_name, "raw_scores")
         )
@@ -331,7 +331,3 @@ def vanilla_biometrics_ztnorm(
         _ = compute_scores(zt_normed_scores, dask_client)
 
     logger.info("Experiment finished !!!!!")
-    if dask_client is not None:
-        logger.info("Shutdown workers !!!!!")
-        dask_client.shutdown()
-        logger.info("Done !!!!!")
\ No newline at end of file

[Manuel Günther]

I just stumbled upon this line. Maybe you want to read the following ;-) http://classicallatin.org/exordium/do-you-use-too-many-exclamation-marks-stop-it

[Tiago de Freitas Pereira]

Hi @amohammadi,

Why that? We should shutdown the client while using the CLI command.

[Amir MOHAMMADI]

dask already does this as part of their clean up.

[Tiago de Freitas Pereira]

It's just a good practice to clean up your stuff. You can have an exception in between and those workers can be opened for a while. It's better to leave this shutdown there.

[Amir MOHAMMADI]

I don't see any try and catch here. Anyway from what I have seen, as soon as the server crashes, dask clients automatically exit. This has been almost instant in my experience.