bob.ap issues
https://gitlab.idiap.ch/bob/bob.ap/-/issues
2017-08-17T14:18:22Z
https://gitlab.idiap.ch/bob/bob.ap/-/issues/4
Crash when calling get_shape(<array>) from FrameExractor
2017-08-17T14:18:22Z
Pavel KORSHUNOV
Crash when calling get_shape(<array>) from FrameExractor
Here is an example that leads to the crash, as posted to `bob-devel` google group:
```python
from bob.ap import *
from bob.io.audio import *
read = reader('test.wav')
data = read.load()
signal = data[0]
fe = FrameExtractor(
samplin...
Here is an example that leads to the crash, as posted to `bob-devel` google group:
```python
from bob.ap import *
from bob.io.audio import *
read = reader('test.wav')
data = read.load()
signal = data[0]
fe = FrameExtractor(
sampling_frequency=48000,
win_length_ms=20,
win_shift_ms=10,
normalize_mean=False)
shape = fe.get_shape(signal) # <= Here it crashes
```
Pavel KORSHUNOV
Pavel KORSHUNOV
https://gitlab.idiap.ch/bob/bob.ap/-/issues/2
Versioning
2017-08-17T14:18:22Z
Tiago de Freitas Pereira
Versioning
Since the last commit made the features change, shall we create a minor version for this package??
This may impact results obtained with `bob.bio.spear`
@bob
Since the last commit made the features change, shall we create a minor version for this package??
This may impact results obtained with `bob.bio.spear`
@bob
https://gitlab.idiap.ch/bob/bob.ap/-/issues/1
Questionable implementation of DCT kernel in Ceps.cpp
2017-08-17T14:18:22Z
André Anjos
Questionable implementation of DCT kernel in Ceps.cpp
*Created by: pkorshunov*
@laurentes and @khoury: Could you please check this issue?
DCT kernel is implemented in Ceps.cpp (see line 103):
m_dct_kernel = dct_coeff * blitz::cos(M_PI*(i+1)*(j+0.5)/(double)(m_n_filters));
I'm ...
*Created by: pkorshunov*
@laurentes and @khoury: Could you please check this issue?
DCT kernel is implemented in Ceps.cpp (see line 103):
m_dct_kernel = dct_coeff * blitz::cos(M_PI*(i+1)*(j+0.5)/(double)(m_n_filters));
I'm not sure if using '(i+1)' index instead of 'i' in the DCT formula is correct. I suspect it is a bug. According to Wikipedia (https://en.wikipedia.org/wiki/Discrete_cosine_transform) and Matlab (http://ch.mathworks.com/help/signal/ref/dct.html), DCT-II, which seems to be the targeted implementation here, should have 'i' instead of 'i+1' as an index.
Also, for the normalization (see Ceps.cpp, line 103):
double dct_coeff = m_dct_norm ? (double)sqrt(2./(double)(m_n_filters)) : 1.;
It seems the normalization is not correct either, since if we choose to use it, we should multiply zeros coefficient by 1/sqrt(2). Here is a clear formula and implementation: https://unix4lyfe.org/dct-1d/
Pavel KORSHUNOV
Pavel KORSHUNOV