Project 'biosignal/software/deepdraw' was moved to 'medai/software/deepdraw'. Please update any links and bookmarks that may still have the old path.
WIP: Object Detection
Merge request reports
Activity
Filter activity
requested review from @andre.anjos
assigned to @arenzom
assigned to @andre.anjos and unassigned @arenzom
removed review request for @andre.anjos
Thanks for this MR, @arenzom. The overall contribution looks great. My only remark concerns the organisation of the package. As of now, detection is "part" of binary segmentation, which looks rather weird and difficult to follow.
I think we need to do a surgery on this package to do the following:
- Create a module called
bob/ip/common
andbob/ip/detect
, which should be parallel tobob/ip/binseg
- Move common code (shared by both detection and binary-segmentation) to
bob/ip/common
. This may include data loading, transformation or re-usable functions of any aspect. - Move all the detection code that you inserted at
bob/ip/binseg
intobob/ip/detect
, by first copying and then "specialising" so that it only does detection (conversely, the binary-segmentation code should only do binary segmentation). If functions are re-used between modules, then move it tobob/ip/common
. In this sensebob detect config
should only list configs related to detection and not to binary-segmentation anymore. The same rationale should be applied to allbob detect
andbob binseg
subcommands. - Make sure that entry points are created in
setup.py
for a new CLI calledbob detect
and that it mimicsbob binseg
, except only detection is concerned. - Modify the documentation so that the APIs are properly documented.
- Create a module called
added 1 commit
- c3991ded - changing setup to distinguish btw binseg and detect
Please register or sign in to reply