From f0b7996ba61b06a5c1df39d3c222f21824c78314 Mon Sep 17 00:00:00 2001
From: Jaden Diefenbaugh <blakcap@users.noreply.github.com>
Date: Thu, 9 Mar 2017 15:58:39 +0100
Subject: [PATCH] also rm all report items when no exps in group
---
.../web/reports/static/reports/app/services/groupsService.js | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/beat/web/reports/static/reports/app/services/groupsService.js b/beat/web/reports/static/reports/app/services/groupsService.js
index cbc8c926f..11d237ace 100644
--- a/beat/web/reports/static/reports/app/services/groupsService.js
+++ b/beat/web/reports/static/reports/app/services/groupsService.js
@@ -36,7 +36,6 @@ angular.module('reportApp').factory('GroupsService', ['reportFactory', function(
// set by the reportController when saving report data
groupsServiceInstance.isEditable = undefined;
groupsServiceInstance.setEditable = (val) => {
- console.log(val);
if(val !== true && val !== false){
throw new Error(`invalid isEditable: ${JSON.stringify(val)}`);
}
@@ -70,7 +69,6 @@ angular.module('reportApp').factory('GroupsService', ['reportFactory', function(
// freeze groups objs, isnt editable
if(!groupsServiceInstance.isEditable){
- console.log('freezing groups');
deepFreeze(groupData);
}
};
@@ -134,6 +132,7 @@ angular.module('reportApp').factory('GroupsService', ['reportFactory', function(
let res = this._experimentNames.delete(expName);
if(this._experimentNames.size === 0){
this.analyzer = '';
+ this.reportItems.forEach(i => this.removeReportItem(i.id));
}
this.unsetExperimentAlias(expName);
@@ -239,7 +238,6 @@ angular.module('reportApp').factory('GroupsService', ['reportFactory', function(
// wipe data and load groups
groupData.splice(0, groupData.length);
let safeData = data || {};
- console.log(safeData);
Object.entries(safeData)
// sometimes we get an empty string for name for some reason
@@ -318,7 +316,6 @@ angular.module('reportApp').factory('GroupsService', ['reportFactory', function(
groupsServiceInstance.urlBase = '';
groupsServiceInstance.saveUrlBase = (url) => {
- console.log(url);
groupsServiceInstance.urlBase = url;
};
--
GitLab