From deaeb6c00b81da1b6f1d0eef3582b686c2fadd99 Mon Sep 17 00:00:00 2001
From: Samuel Gaist <samuel.gaist@idiap.ch>
Date: Fri, 17 Apr 2020 10:20:12 +0200
Subject: [PATCH] [common][api] Simplify reverse args creation for view URL
The items needed are the same as provided by the fullname method.
This allows to integrate the Experiment creation serializer
---
beat/web/common/api.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/beat/web/common/api.py b/beat/web/common/api.py
index c18ae90a1..e81c39e16 100644
--- a/beat/web/common/api.py
+++ b/beat/web/common/api.py
@@ -171,10 +171,6 @@ class ListCreateBaseView(
else:
return BadRequestResponse(serializer.errors)
- html_view_args = [db_object.name, db_object.version]
- if hasattr(db_object, "author"):
- html_view_args.insert(0, db_object.author.username)
-
result = {
"name": db_object.name,
"full_name": db_object.fullname(),
@@ -182,7 +178,8 @@ class ListCreateBaseView(
+ db_object.fullname()
+ "/",
"object_view": reverse(
- "{}:view".format(self.namespace.split("_")[1]), args=html_view_args
+ "{}:view".format(self.namespace.split("_")[1]),
+ args=db_object.fullname().split("/"),
),
}
--
GitLab