From c035a044e0a824c5b1639c3aa7458083d512d244 Mon Sep 17 00:00:00 2001 From: Samuel Gaist <samuel.gaist@idiap.ch> Date: Thu, 26 Apr 2018 15:51:04 +0200 Subject: [PATCH] [plotters][serializers] Fix key search in dictionaries --- beat/web/plotters/serializers.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/beat/web/plotters/serializers.py b/beat/web/plotters/serializers.py index 3577c9f53..5f79e3ca8 100644 --- a/beat/web/plotters/serializers.py +++ b/beat/web/plotters/serializers.py @@ -119,7 +119,7 @@ class PlotterParameterCreationSerializer(ContributionCreationSerializer): def create(self, validated_data): plotterparameter = None - if not validated_data.has_key("name"): + if "name" not in validated_data: raise serializers.ValidationError('No name provided') try: @@ -130,7 +130,7 @@ class PlotterParameterCreationSerializer(ContributionCreationSerializer): if plotterparameter is not None: raise serializers.ValidationError('A plotterparameter with this name already exists') - if not self.data.has_key("plotter"): + if "plotter" not in self.data: raise serializers.ValidationError('No plotter provided') plotter = None @@ -142,11 +142,11 @@ class PlotterParameterCreationSerializer(ContributionCreationSerializer): if plotter is None: raise serializers.ValidationError('Required plotter does not exist') - if not validated_data.has_key("data"): + if "data" not in validated_data: validated_data['data'] = {} #Only create new version for latest version - if validated_data.has_key("previous_version"): + if "previous_version" in validated_data: if validated_data['previous_version'].version < validated_data['version'] - 1: raise serializers.ValidationError('A new version for this plotterparameter version already exist') @@ -155,7 +155,7 @@ class PlotterParameterCreationSerializer(ContributionCreationSerializer): validated_data['description'] = validated_data['previous_version'].description #Create fork - if validated_data.has_key("fork_of"): + if "fork_of" in validated_data: #add description/short_description to new version validated_data['short_description'] = validated_data['fork_of'].short_description validated_data['description'] = validated_data['fork_of'].description -- GitLab