diff --git a/beat/web/reports/static/reports/test/report-spec.js b/beat/web/reports/static/reports/test/report-spec.js index b68c034ad72747e4a5b7bf64ac67efe452aa699a..744037f10e1b4c2d54d1cc7d42a005c7a9a6be32 100644 --- a/beat/web/reports/static/reports/test/report-spec.js +++ b/beat/web/reports/static/reports/test/report-spec.js @@ -385,20 +385,17 @@ describe('reports app', function(){ const g1ExpPanel = element(by.css('#collapse-group1 > .panel-body > .panel')); const addButton = element(by.css('#group1_exp_add_dropdown')); - const addFirstExpToGroup1 = () => { + // add back the exp to group1 + afterAll(function(){ return addButton.click() .then(() => { + // make sure list opened correctly & add an exp const parent = addButton.element(by.xpath('..')); const list = parent.element(by.css('ul')); + const lis = list.all(by.css('li')); - return list.get(0).element(by.css('a')).click(); + return lis.get(0).element(by.css('a')).click(); }); - - }; - - // add back the exp to group1 - afterAll(function(){ - return addFirstExpToGroup1(); }); it('adds 1 experiment to group1', function(){ @@ -409,9 +406,10 @@ describe('reports app', function(){ const parent = addButton.element(by.xpath('..')); expect(parent.getAttribute('class')).toContain('open'); const list = parent.element(by.css('ul')); - expect(list.all(by.css('li')).count()).toBeGreaterThan(0); + const lis = list.all(by.css('li')); + expect(lis.count()).toBeGreaterThan(0); - return list.get(0).element(by.css('a')).click(); + return lis.get(0).element(by.css('a')).click(); }) .then(() => { // check state of group after adding exp @@ -510,7 +508,7 @@ describe('reports app', function(){ expCount, element('#group1_exp_add_dropdown').element(by.xpath('..')).element(by.css('ul')).all(by.css('li')).count() ]) - ); + ) .then(([expCount, optsCount]) => { expect(expCount).toBe(optsCount); });