Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • beat.editor beat.editor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • beatbeat
  • beat.editorbeat.editor
  • Issues
  • #244
Closed
Open
Issue created Jul 18, 2019 by Samuel GAIST@samuel.gaistOwner

Improve plotter new creation handling

Summary

Currently when creating a new Plotter, the prototype contains "plot/unknown/1".

This has problematic implications:

  • The editor will fail to load it
  • Test will fail because the editor can't load that dataformat

Steps to reproduce

  1. Click on new
  2. Select Plotter
  3. Try to edit the plotter created

What is the current bug behavior?

An error is raised and it make the application fail

What is the expected correct behavior?

Either:

  • Show a dialog asking to select a dataformat to use.
  • Select a suitable dataformat from the prefix. Maybe a simple default like for the algorithm prototype.

Possible fixes

One possibility could be to have a method called after the dialog has been closed that can be re-implemented in sub-classes to do whatever is needed for the newly created object. Another would be to move the dialog logic in its own method so re-implementing _createNewAsset would be easier.

Note that this affects !101 (merged)

Edited Jul 19, 2019 by Flavio TARSETTI
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking