beat.editor issueshttps://gitlab.idiap.ch/beat/beat.editor/-/issues2020-08-10T12:44:08Zhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/185Experiment Editor2020-08-10T12:44:08ZJaden DIEFENBAUGHExperiment EditorThis issue tracks the implementation of the experiment editor.
As this editor is more complex regarding object management as well as setup, the work will be done in several steps:
* [x] Blocks edition
* [x] Toolchain preview
* [x] S...This issue tracks the implementation of the experiment editor.
As this editor is more complex regarding object management as well as setup, the work will be done in several steps:
* [x] Blocks edition
* [x] Toolchain preview
* [x] Smart filtering
Unlike all other BEAT assets, creating a new experiment requires an additional step therefore, a dedicated task is needed with regard to the creation of such a new asset:
* [x] Add support for new experiment creation to asset dialog[v2] 3 - Experiment editorSamuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.editor/-/issues/176toolchain naming2019-02-07T15:06:01ZFlavio TARSETTItoolchain namingDuring our ALLIES meeting, it has been shown that adding multiple inputs in an object overwrites the names.
For it to work, we need to "add input" then "Save" every time and then re-open the object add another input etc.
What we expect...During our ALLIES meeting, it has been shown that adding multiple inputs in an object overwrites the names.
For it to work, we need to "add input" then "Save" every time and then re-open the object add another input etc.
What we expect is that adding multiples inputs shouldn't overwrite the previous input names.
@jdiefenbaugh : Can you fix this please? Thanks.[v1] Ongoing patching until [v2] is readyJaden DIEFENBAUGHJaden DIEFENBAUGHhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/174JSON schema duplication2019-03-07T21:13:26ZSamuel GAISTJSON schema duplicationThe files found in the conda/js/src/helpers/schema/ subfolder are basically duplicates of the schemas defined in beat.core.
This is wrong on several levels:
- Code duplication
- They are out of sync with the current beat.core version
-...The files found in the conda/js/src/helpers/schema/ subfolder are basically duplicates of the schemas defined in beat.core.
This is wrong on several levels:
- Code duplication
- They are out of sync with the current beat.core version
- The folder content is not even a copy of the beat.core content so they are currently different
- New versions of the schema are not available
The only official schemas are the ones from beat.core. Those must be used and not copied.
Relates to #140 [v1] Ongoing patching until [v2] is readyJaden DIEFENBAUGHJaden DIEFENBAUGHhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/169cannot build the virtual image for beat editor.2018-11-20T18:08:52ZZohreh MOSTAANIcannot build the virtual image for beat editor.I cannot make the VM even after using the ``june-allies`` branch.
I installed the packer. The only command I could run is ``packer`` not ``packer-io`` and when I run ``packer build ubuntu-18.04-beat.json`` I get this error:
```
virtualb...I cannot make the VM even after using the ``june-allies`` branch.
I installed the packer. The only command I could run is ``packer`` not ``packer-io`` and when I run ``packer build ubuntu-18.04-beat.json`` I get this error:
```
virtualbox-iso output will be in this color.
==> virtualbox-iso: Downloading or copying Guest additions
virtualbox-iso: Downloading or copying: file:///usr/share/virtualbox/VBoxGuestAdditions.iso
==> virtualbox-iso: Downloading or copying ISO
virtualbox-iso: Downloading or copying: file://./iso/ubuntu-18.04-server-amd64.iso
virtualbox-iso: Error downloading: open /idiap/user/zmostaani/experiments/beat.tutorial/packer_scripts/iso/ubuntu-18.04-server-amd64.iso: no such file or directory
virtualbox-iso: Downloading or copying: http://cdimage.ubuntu.com/ubuntu/releases/bionic/release/ubuntu-18.04-server-amd64.iso
virtualbox-iso: Error downloading: Error making HTTP GET request: 404 Not Found
==> virtualbox-iso: ISO download failed.
Build 'virtualbox-iso' errored: ISO download failed.
```
I followed the steps in the documentation. I am using idiap's workstation which has VirtualBox installed.
It is related to issues #148 and #150.https://gitlab.idiap.ch/beat/beat.editor/-/issues/167[plotterparameter] first plotter selected instead of blank selection and sche...2018-10-31T13:05:04ZFlavio TARSETTI[plotterparameter] first plotter selected instead of blank selection and schema validation is wrong (having 1 plotter selected is a requirement)As in #154 and fixed in my MR !23 we have the same issue for the plotterparameter component:
The selector by default shows the first available plotter as selected, but it should really show a "blank" selection, prompting the user to choo...As in #154 and fixed in my MR !23 we have the same issue for the plotterparameter component:
The selector by default shows the first available plotter as selected, but it should really show a "blank" selection, prompting the user to choose a plotter. It tricks the user to believe that he has selected something BUT in the json file there's no plotter selected.
The plotterparameter believes it is valid even without any plotter. This needs to be fixedFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/166[tests] no input validation and empty test files2019-01-21T18:41:25ZFlavio TARSETTI[tests] no input validation and empty test filesA large number of tests for each components are missing and need to be fixed:
- input validation are missing in the `ParameterCreate.jsx`
- some files such as `PlotterParameterEditor.spec.jsx, PlotterEditor.spec.jsx` are empty files (I ...A large number of tests for each components are missing and need to be fixed:
- input validation are missing in the `ParameterCreate.jsx`
- some files such as `PlotterParameterEditor.spec.jsx, PlotterEditor.spec.jsx` are empty files (I am currently working on the `PlotterEditor.spec.jsx`)https://gitlab.idiap.ch/beat/beat.editor/-/issues/165beat editor is down again with new error. may be relavant to issue #149.2019-01-09T18:52:34ZZohreh MOSTAANIbeat editor is down again with new error. may be relavant to issue #149.This time I do not get a blank page when I run the editor but when I check any of the tabs (experiments, algorithms) etc I get a blank page. It happened in the middle of editing some experiment but I do not know where is the problem beca...This time I do not get a blank page when I run the editor but when I check any of the tabs (experiments, algorithms) etc I get a blank page. It happened in the middle of editing some experiment but I do not know where is the problem because the experiment is running.
I get this error on the firefox console:
```
too much recursion[Learn More]
```
and this error on the terminal:
```
[2018-10-15 16:39:26,355] ERROR in app: Exception on /algorithms [GET]
Traceback (most recent call last):
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask_restful/__init__.py", line 480, in wrapper
resp = resource(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/views.py", line 88, in view
return self.dispatch_request(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask_restful/__init__.py", line 595, in dispatch_request
resp = meth(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 339, in get
return self.refresh()
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 333, in refresh
return generate_entity_tree(entity, self.config)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 213, in generate_entity_tree
for f in obj['children']:
KeyError: 'children'
Exception on /algorithms [GET]
Traceback (most recent call last):
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask_restful/__init__.py", line 480, in wrapper
resp = resource(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask/views.py", line 88, in view
return self.dispatch_request(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/flask_restful/__init__.py", line 595, in dispatch_request
resp = meth(*args, **kwargs)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 339, in get
return self.refresh()
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 333, in refresh
return generate_entity_tree(entity, self.config)
File "/idiap/user/zmostaani/miniconda3/envs/beat_py3/lib/python3.6/site-packages/beat/editor/resources.py", line 213, in generate_entity_tree
for f in obj['children']:
KeyError: 'children'
```https://gitlab.idiap.ch/beat/beat.editor/-/issues/162[algorithm] a "warning" for algorithms2019-01-18T18:01:51ZFlavio TARSETTI[algorithm] a "warning" for algorithmsA strange warning appears when loading algorithms in the interface:
```
Warning: Failed prop type: Invalid prop `children` supplied to `Form`, expected a ReactNode.
in Form (created by AlgorithmEditor)
in AlgorithmEditor (create...A strange warning appears when loading algorithms in the interface:
```
Warning: Failed prop type: Invalid prop `children` supplied to `Form`, expected a ReactNode.
in Form (created by AlgorithmEditor)
in AlgorithmEditor (created by Connect(AlgorithmEditor))
in Connect(AlgorithmEditor) (created by EntityDetail)
in div (created by TabPane)
in TabPane (created by EntityDetail)
in div (created by TabContent)
in TabContent (created by EntityDetail)
in div (created by Col)
in Col (created by EntityDetail)
in div (created by Row)
in Row (created by EntityDetail)
in div (created by Container)
in Container (created by EntityDetail)
in EntityDetail (created by Connect(EntityDetail))
in Connect(EntityDetail) (created by Route)
in Route (created by EntityHome)
in Switch (created by EntityHome)
in EntityHome (created by MainContent)
in div (created by MainContent)
in MainContent (created by Route)
in Route (created by App)
in Switch (created by App)
in div (created by Container)
in Container (created by App)
in Router (created by HashRouter)
in HashRouter (created by App)
in App (created by HotExportedApp)
in AppContainer (created by HotExportedApp)
in HotExportedApp
in Provider
printWarning @ checkPropTypes.js:19
checkPropTypes @ checkPropTypes.js:82
validatePropTypes @ react.development.js:1300
createElementWithValidation @ react.development.js:1388
React$$1.createElement @ react-hot-loader.development.js:964
AlgorithmEditor.render @ AlgorithmEditor.jsx:566
finishClassComponent @ react-dom.development.js:13193
updateClassComponent @ react-dom.development.js:13155
beginWork @ react-dom.development.js:13824
performUnitOfWork @ react-dom.development.js:15863
workLoop @ react-dom.development.js:15902
renderRoot @ react-dom.development.js:15942
performWorkOnRoot @ react-dom.development.js:16560
performWork @ react-dom.development.js:16482
performSyncWork @ react-dom.development.js:16454
interactiveUpdates$1 @ react-dom.development.js:16719
interactiveUpdates @ react-dom.development.js:2150
dispatchInteractiveEvent @ react-dom.development.js:4532
```Jaden DIEFENBAUGHJaden DIEFENBAUGHhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/161[validation] types and values for parameters not properly checked in editor/ ...2020-02-12T12:23:03ZFlavio TARSETTI[validation] types and values for parameters not properly checked in editor/ second issue old value saved@jdiefenbaugh : The editor presents some validation bugs
The editor seems to have unexpected behavior for validation of parameters.
A `string value` could be saved in a `int8`, and this is valid and could be saved in the `json` file.
...@jdiefenbaugh : The editor presents some validation bugs
The editor seems to have unexpected behavior for validation of parameters.
A `string value` could be saved in a `int8`, and this is valid and could be saved in the `json` file.
A second issue comes from the fact that all parameters have their old value saved somewhere in the props or state history.
For example if we suddenly decide to change the parameter type from `"string"` to `"int"`, the value `"helloworld"` will be kept as the value for the `"int"`Jaden DIEFENBAUGHJaden DIEFENBAUGHhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/154A few issues with the Plotter editor2018-10-31T13:05:05ZJaden DIEFENBAUGHA few issues with the Plotter editor- The dataformat select by default shows the first available plotter dataformat as selected, but it should really show a "blank" selection, prompting the user to choose a dataformat
- The default value for (only `bool`-type?) parameters ...- The dataformat select by default shows the first available plotter dataformat as selected, but it should really show a "blank" selection, prompting the user to choose a dataformat
- The default value for (only `bool`-type?) parameters arent saved to the metadata
- There's no way to add libraries to the plotter!Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/150Specify the `june-allies` branch of `beat.tutorial` in documentation2018-12-19T19:02:44ZJaden DIEFENBAUGHSpecify the `june-allies` branch of `beat.tutorial` in documentationhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/146The page refreshes everytime I try to change the name of a block in a toolchain2018-08-22T06:50:08ZZohreh MOSTAANIThe page refreshes everytime I try to change the name of a block in a toolchainI am trying to make a new toolchain. When I want to change the name of the block the small box for adjusting the inputs and outputs of block refreshes. It closes and opens again in a split second. It happens only when changing the name o...I am trying to make a new toolchain. When I want to change the name of the block the small box for adjusting the inputs and outputs of block refreshes. It closes and opens again in a split second. It happens only when changing the name of the block but not when changing the inputs and outputs name and it happens by writing or deleting each letter. Very annoying! I would really appreciate if you could give a temporary solution to me if it will take time to fix this issue. Please let me know if you need any information.https://gitlab.idiap.ch/beat/beat.editor/-/issues/144fix connection line ids prepending '#' to id name2018-12-19T19:02:44ZJaden DIEFENBAUGHfix connection line ids prepending '#' to id nameObviously my wires crossed at some point - the `line`s in `ToolchainConnections` have ids that start with '#', making it very hard to select a line by id:
```js
document.querySelector('#\\#training_data-measurements-training_alg-measurem...Obviously my wires crossed at some point - the `line`s in `ToolchainConnections` have ids that start with '#', making it very hard to select a line by id:
```js
document.querySelector('#\\#training_data-measurements-training_alg-measurements');
```
Woops!Toolchain Editor: Fixeshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/143The connection in the toolchain is not being updated properly2018-12-19T19:02:44ZZohreh MOSTAANIThe connection in the toolchain is not being updated properlyI made a toolchain from scratch by looking at tutorial/eigenface/1 . I made some mistakes in connecting the endpoints but at the end I corrected them and all the names and connections in my toolchain were the same as this toolchain. Then...I made a toolchain from scratch by looking at tutorial/eigenface/1 . I made some mistakes in connecting the endpoints but at the end I corrected them and all the names and connections in my toolchain were the same as this toolchain. Then I used my toolchain in an experiment but it was not working. It said that the toolchain is not valid because certain connections are wrong. Looking at the json file of the toolchain, it turned out that the correct connections are added to the list of connections without the previous wrong ones being removed from them and therefore the error. I must say that in the beat editor gui everything seemed correct and valid.Toolchain Editor: FixesJaden DIEFENBAUGHJaden DIEFENBAUGHhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/142cannot unassign an algorithm to a block in the experiment.2018-12-19T19:02:44ZZohreh MOSTAANIcannot unassign an algorithm to a block in the experiment.After choosing an algorithm for a block in an experiment it is not possible to assign no algorithm to that block. It is only possible to choose from certain algorithms. This is not the case for the Database though. If there is a problem ...After choosing an algorithm for a block in an experiment it is not possible to assign no algorithm to that block. It is only possible to choose from certain algorithms. This is not the case for the Database though. If there is a problem in the toolchain and you want to find out where the problem is it would be a good option to unassign an algorithm without deleting the whole block.Experiment Editor: Fixeshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/139Add Jinja2 template for plotter editor2018-10-02T12:13:23ZJaden DIEFENBAUGHAdd Jinja2 template for plotter editorTurns out, the plotter editor doesn't have a template file!
@flavio.tarsetti this would be a great intro issue to see & work with the whole systemTurns out, the plotter editor doesn't have a template file!
@flavio.tarsetti this would be a great intro issue to see & work with the whole systemFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.editor/-/issues/131Weird edgecases with toolchain validity2018-12-19T19:02:44ZJaden DIEFENBAUGHWeird edgecases with toolchain validityRarely it seems that a toolchain is valid but somehow it's not...
will hopefully probably be fixed by the refactoring & test fixingRarely it seems that a toolchain is valid but somehow it's not...
will hopefully probably be fixed by the refactoring & test fixingToolchain Editor: Fixeshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/129Block editor should allow switching inputs2018-12-19T19:02:44ZJaden DIEFENBAUGHBlock editor should allow switching inputsThis is a little tricky - say you have two inputs, `input1` and `input2`. Trying to change the first name to `input2` will fail obviously since there's already an `input2`. But you want to switch them. The only solution now is using a 3r...This is a little tricky - say you have two inputs, `input1` and `input2`. Trying to change the first name to `input2` will fail obviously since there's already an `input2`. But you want to switch them. The only solution now is using a 3rd name to switch, but this isn't super logical...
not sure how to fix this.Toolchain Editor: UX Improvementshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/127Don't remove type inference after an algorithm has been selected for a block2018-12-19T19:02:44ZJaden DIEFENBAUGHDon't remove type inference after an algorithm has been selected for a blockBefore an algorithm is selected, the dropdown menu for algs is filtered via type-inference as it should be. But, after you select an alg and go to select a different one, the type inference filtering is dropped.
Pretty sure I added this...Before an algorithm is selected, the dropdown menu for algs is filtered via type-inference as it should be. But, after you select an alg and go to select a different one, the type inference filtering is dropped.
Pretty sure I added this as a feature but now it's a bug :')Experiment Editor: Fixeshttps://gitlab.idiap.ch/beat/beat.editor/-/issues/126Fix exp editor assigning datasets wrongly when choosing protocol2018-11-20T19:14:16ZJaden DIEFENBAUGHFix exp editor assigning datasets wrongly when choosing protocolWhen creating an iris experiment, training & testing were assigned wrongly (why???)When creating an iris experiment, training & testing were assigned wrongly (why???)Experiment Editor: Fixes