Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
beat
beat.editor
Commits
fa2030ad
Commit
fa2030ad
authored
Jan 14, 2019
by
Jaden
Browse files
added parametercreate tests & fixed default value bug,
#166
parent
58615541
Pipeline
#25938
passed with stages
in 47 minutes and 6 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
conda/js/src/components/ParameterCreate.jsx
View file @
fa2030ad
...
...
@@ -349,7 +349,7 @@ export default class ParameterCreate extends React.Component<Props, State> {
value
=
{
true
}
onChange
=
{
(
e
)
=>
updateParameter
(
name
,
{
...
param
,
default
:
JSON
.
parse
(
e
.
target
.
val
ue
)
default
:
tr
ue
})
}
/>
True
...
...
@@ -364,7 +364,7 @@ export default class ParameterCreate extends React.Component<Props, State> {
value
=
{
false
}
onChange
=
{
(
e
)
=>
updateParameter
(
name
,
{
...
param
,
default
:
JSON
.
parse
(
e
.
target
.
value
)
default
:
false
})
}
/>
False
...
...
conda/js/src/components/ParameterCreate.spec.jsx
View file @
fa2030ad
//// @flow
//import React from 'react';
//import { expect } from 'chai';
//import { mount } from 'enzyme';
//import sinon from 'sinon';
//import { spies } from '@test';
//
//import C from './ParameterCreate.jsx';
//
//describe.only('<ParameterCreate />', () => {
// let wrapper;
// const name = 'parameter';
// // shortcut for a func to update just the parameter obj, not the name
// const _updateParameter = (name, p, oldName) => {
// wrapper.setProps({
// param: p,
// });
// };
// const params = [];
//
// afterEach(() => {
// if(wrapper && wrapper.unmount)
// wrapper.unmount();
// });
//
// it(`saves the default value of a boolean parameter`, () => {
// let param = {
// type: '',
// default: '',
// description: '',
// };
// const updateParameter = sinon.spy(_updateParameter);
//
// wrapper = mount(
// <C
// name={name}
// param={param}
// params={params}
// updateParameter={updateParameter}
// />
// );
//
// // sanity checks
// expect(wrapper.find('TypedField')).to.have.prop('name', name);
//
// wrapper.find('Input.custom-select').prop('onChange')( { target: { value: 'bool' }});
// wrapper.update();
// console.log(wrapper.props().param);
// expect(wrapper.props().param).to.deep.equal(
// {
// type: 'bool',
// default: '',
// description: '',
// }
// );
//
// // wrapper.find('input[type="radio"]').at(0).simulate('change', { target: { checked: 'true' }});;
// wrapper.find('input[type="radio"]').at(0).simulate('change', { target: { value: 'true' }});;
// wrapper.update();
// expect(updateParameter.args[0]).to.deep.equal([
// name,
// {
// type: 'bool',
// default: 'true',
// description: '',
// }
// ]);
// });
//});
// @flow
import
React
from
'
react
'
;
import
{
expect
}
from
'
chai
'
;
import
{
mount
}
from
'
enzyme
'
;
import
sinon
from
'
sinon
'
;
import
{
spies
}
from
'
@test
'
;
import
C
from
'
./ParameterCreate.jsx
'
;
describe
(
'
<ParameterCreate />
'
,
()
=>
{
let
wrapper
;
const
name
=
'
parameter
'
;
// shortcut for a func to update just the parameter obj, not the name
const
_updateParameter
=
(
name
,
p
,
oldName
)
=>
{
wrapper
.
setProps
({
param
:
p
,
});
};
const
params
=
[];
afterEach
(()
=>
{
if
(
wrapper
&&
wrapper
.
unmount
)
wrapper
.
unmount
();
});
it
(
`saves the default value of a boolean parameter`
,
()
=>
{
let
param
=
{
type
:
''
,
default
:
''
,
description
:
''
,
};
const
updateParameter
=
sinon
.
spy
(
_updateParameter
);
wrapper
=
mount
(
<
C
name
=
{
name
}
param
=
{
param
}
params
=
{
params
}
updateParameter
=
{
updateParameter
}
/>
);
// sanity checks
expect
(
wrapper
.
find
(
'
TypedField
'
)).
to
.
have
.
prop
(
'
name
'
,
name
);
wrapper
.
find
(
'
Input.custom-select
'
).
prop
(
'
onChange
'
)(
{
target
:
{
value
:
'
bool
'
}});
wrapper
.
update
();
expect
(
wrapper
.
props
().
param
).
to
.
deep
.
equal
(
{
type
:
'
bool
'
,
default
:
''
,
description
:
''
,
}
);
wrapper
.
find
(
'
input[type="radio"]
'
).
at
(
0
).
simulate
(
'
change
'
,
{
target
:
{
checked
:
'
true
'
}});;
//wrapper.find('input[type="radio"]').at(0).simulate('change', { target: { value: 'true' }});;
wrapper
.
update
();
expect
(
wrapper
.
props
().
param
).
to
.
deep
.
equal
({
type
:
'
bool
'
,
default
:
true
,
description
:
''
,
});
});
});
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment