beat.core merge requestshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests2022-02-25T13:11:29Zhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/142Fix stats retrieval and test DB environments2022-02-25T13:11:29ZSamuel GAISTFix stats retrieval and test DB environmentsThis merge request fixes both issues found in #108.
The stats retrieval no tries to retrieve the data such that cgroup V1 data can be used or fallback to something else for V2.
It also updates the prefix in order to ensure the use of t...This merge request fixes both issues found in #108.
The stats retrieval no tries to retrieve the data such that cgroup V1 data can be used or fallback to something else for V2.
It also updates the prefix in order to ensure the use of the same database environment that the one pulled at the start of the tests.
Fixes #108Samuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/138Gracefully handle docker client creation error2021-04-13T12:14:31ZSamuel GAISTGracefully handle docker client creation errorUp until now, the client creation did not fail when Docker daemon was not running but the behaviour seems to have changed on macOS.
In any case, ensuring that the client creation failure does follow the rest of the logic is the right ...Up until now, the client creation did not fail when Docker daemon was not running but the behaviour seems to have changed on macOS.
In any case, ensuring that the client creation failure does follow the rest of the logic is the right thing to do.
Fixes #107
Fixes beat/beat.editor#282Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/135Fix generated protocol templates2021-01-29T17:38:21ZSamuel GAISTFix generated protocol templatesThe original work done for the protocol template was working however it has been discovered that the helper script did not correctly generate the protocol templates.
The script has been fixed in !134 however the test data were not.
Thi...The original work done for the protocol template was working however it has been discovered that the helper script did not correctly generate the protocol templates.
The script has been fixed in !134 however the test data were not.
This merge request fixes that. As a byproduct of this cleanup, it has been found that the large database was in fact wrongly written and thus has been fixed as well.André AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/134Fix protocole template creation when migrating a database2021-01-29T16:55:46ZSamuel GAISTFix protocole template creation when migrating a databaseThe wrong name was used to generate the template.
Also improve handling of protocol template double creation.
If the content is different warn the user and ask
whether it should continue with the database creation.The wrong name was used to generate the template.
Also improve handling of protocol template double creation.
If the content is different warn the user and ask
whether it should continue with the database creation.André AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/131Fix algorithm name pattern in experiment globals2020-11-12T12:20:40ZSamuel GAISTFix algorithm name pattern in experiment globalsIt's missing support for - in the author part of
algorithm author name.
Fixes #104It's missing support for - in the author part of
algorithm author name.
Fixes #104Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/125Add minimal rw tmpfs for /tmp and /run2020-07-29T09:18:52ZSamuel GAISTAdd minimal rw tmpfs for /tmp and /runAt least in production, some issues happened that required
to have /tmp writable. To preserve the read-only state
of the container, use a small tmpfs that is enough for
the container to run. /run is another that might be needed
so make i...At least in production, some issues happened that required
to have /tmp writable. To preserve the read-only state
of the container, use a small tmpfs that is enough for
the container to run. /run is another that might be needed
so make it part of the defaults used.
Fixes #101Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/121Fix database prototype2020-06-18T13:58:35ZSamuel GAISTFix database prototypeThe database prototype setup method has a wrong signature and is used in beat/beat.editor> when creating a new Database asset.
This merge request fixes it as well as add the call to the default implementation which is mandatory for ever...The database prototype setup method has a wrong signature and is used in beat/beat.editor> when creating a new Database asset.
This merge request fixes it as well as add the call to the default implementation which is mandatory for everything to be setup properly.
The setup method has been added to two Views in the test prefix so that its use is also tested.
Fixes #97Soft loopshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/117Add size constraint for description field2020-03-12T16:01:52ZSamuel GAISTAdd size constraint for description fieldThis merge request adds a size constraint to ensure that the description field is not longer than what is allowed in beat/beat.web>
Fixes #95
Related to beat/beat.editor#255This merge request adds a size constraint to ensure that the description field is not longer than what is allowed in beat/beat.web>
Fixes #95
Related to beat/beat.editor#255Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/113Add missing variable initialisation for optional argument in worker script2020-02-25T08:35:56ZSamuel GAISTAdd missing variable initialisation for optional argument in worker scriptThe variable initialisation was missing when calling the script without using the `--docker` option.The variable initialisation was missing when calling the script without using the `--docker` option.Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/112Improve disconnection handling2020-02-20T16:18:56ZSamuel GAISTImprove disconnection handlingWhen reloading a worker node, the broker will notice after the usual timeout that it was gone. This is the same as if a node loses its network connection or gets killed.
This wasn't an issue before because the restart of the worker scri...When reloading a worker node, the broker will notice after the usual timeout that it was gone. This is the same as if a node loses its network connection or gets killed.
This wasn't an issue before because the restart of the worker script was "slow" due to the enumeration of all BEAT related docker images. If a node uses the new labeled images, the restart is way faster and thus the broker will have an invalid state.
This patch fixes that by sending a notification to the broker that the worker node is disconnecting. This will make the broker cleanup the entry and have it ready once the worker is back online.Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/109Improve handling of message handler shutdown in local executor2020-02-07T08:33:37ZSamuel GAISTImprove handling of message handler shutdown in local executorIf one of the message handler was not started before joined, it would raise an error.
See [Python.threading.Thread.join](https://docs.python.org/3/library/threading.html#threading.Thread.join)
Relates to beat/beat.backend.python#30If one of the message handler was not started before joined, it would raise an error.
See [Python.threading.Thread.join](https://docs.python.org/3/library/threading.html#threading.Thread.join)
Relates to beat/beat.backend.python#30Flavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/108Handle docker exception following the raise on error property for the new env...2020-01-29T13:15:18ZSamuel GAISTHandle docker exception following the raise on error property for the new environment discoveryIF docker is installed or the daemon not accessible, the exception
propagation will not follow the raise on error property. This patch
fixes that and thus keeps the behaviour consistant.
Fixes #93IF docker is installed or the daemon not accessible, the exception
propagation will not follow the raise on error property. This patch
fixes that and thus keeps the behaviour consistant.
Fixes #93Soft loopsAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/105Remove loops from representation in toolchain schema2020-01-14T09:21:00ZSamuel GAISTRemove loops from representation in toolchain schemaThe blocks entry covers them as it already covers both
the blocks and analysers. Therefore there's no need for
an additional property here.The blocks entry covers them as it already covers both
the blocks and analysers. Therefore there's no need for
an additional property here.Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/103Improve protocol template lookup for database prototype2019-11-08T09:20:47ZSamuel GAISTImprove protocol template lookup for database prototypeRather than blindingly selecting the first protocol template
found, look for the first valid one.
Fixes beat/beat.editor#249Rather than blindingly selecting the first protocol template
found, look for the first valid one.
Fixes beat/beat.editor#249Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/93Fix loop parameters handling2019-09-18T14:45:01ZSamuel GAISTFix loop parameters handlingFor the loop related algorithm only the globals entry was taken into account.
This patch fixes this and modifies the tests to take that into account.For the loop related algorithm only the globals entry was taken into account.
This patch fixes this and modifies the tests to take that into account.Soft loopsAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/91Improve loop algorithms crosschecking for experiment2019-09-17T15:09:47ZSamuel GAISTImprove loop algorithms crosschecking for experimentThe current technique use had a flaw. With algorithm containing
a different number of groups, it would truncate the to the shortest
as explained in the zip function documentation.
Now itertools.zip_longest is used to ensure that the ite...The current technique use had a flaw. With algorithm containing
a different number of groups, it would truncate the to the shortest
as explained in the zip function documentation.
Now itertools.zip_longest is used to ensure that the iteration is
done on the longest input.Soft loopsAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/82Update algorithm for loop user new types2019-07-15T08:51:27ZSamuel GAISTUpdate algorithm for loop user new typesThis merge request updates the algorithm schema
to properly handle the two types of loop user
algorithm.
It also fixes dataformats parsing when loading
an algorithm following the same work done in
beat/beat.backend.python!56
It...This merge request updates the algorithm schema
to properly handle the two types of loop user
algorithm.
It also fixes dataformats parsing when loading
an algorithm following the same work done in
beat/beat.backend.python!56
It also updates the prefix to improve testing.Soft loopsAndré AnjosAndré Anjoshttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/75Add missing class variables to plotter storage2019-05-15T10:31:30ZSamuel GAISTAdd missing class variables to plotter storageFixes the plotter storage class by adding missing class member variables.
The miss went unnoticed because the CodeStorage base class is not a subclass of Storage.Fixes the plotter storage class by adding missing class member variables.
The miss went unnoticed because the CodeStorage base class is not a subclass of Storage.Soft loopsSamuel GAISTSamuel GAISThttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/73Fix plotterparameter writing2019-05-06T13:35:08ZSamuel GAISTFix plotterparameter writingThe write method was wrong as well as there were missing
pieces in the class for it to work properly.
This merge request fixes all these points.
Fixes #78The write method was wrong as well as there were missing
pieces in the class for it to work properly.
This merge request fixes all these points.
Fixes #78Soft loopsFlavio TARSETTIFlavio TARSETTIhttps://gitlab.idiap.ch/beat/beat.core/-/merge_requests/61Decode algorithm prototype content if python is older than 3.62019-03-15T10:41:57ZSamuel GAISTDecode algorithm prototype content if python is older than 3.6Fixes #71Fixes #71André AnjosAndré Anjos