[test][dataformats] Moved local test to AssetLocalTest

beat/cmdline/test/test_dataformats.py

@@ -39,156 +39,110 @@
 import nose.tools
 import click
 from click.testing import CliRunner
-from . import platform, disconnected, prefix, tmp_prefix, user, token
-from ..common import Selector
+
 from beat.cmdline.scripts import main_cli
 from beat.core.test.utils import slow, cleanup, skipif
 from beat.core.dataformat import Storage, DataFormat
 
+from . import core
+from . import platform, disconnected, prefix, tmp_prefix, user, token
 
-def call(*args, **kwargs):
-  '''A central mechanism to call the main routine with the right parameters'''
-
-  use_prefix = kwargs.get('prefix', prefix)
-  use_platform = kwargs.get('platform', platform)
-
-  runner = CliRunner()
-  with runner.isolated_filesystem():
-    result = runner.invoke(
-        main_cli.main,
-        ['--test-mode', '--prefix', use_prefix, '--token', token,
-        '--user', user, '--platform', use_platform, 'dataformats'] +
-        list(args)
-    )
-  if result.exit_code != 0:
-      click.echo(result.output)
-  return result.exit_code
 
+def call(*args, **kwargs):
+    """A central mechanism to call the main routine with the right parameters"""
+
+    use_prefix = kwargs.get("prefix", prefix)
+    use_platform = kwargs.get("platform", platform)
+
+    runner = CliRunner()
+    with runner.isolated_filesystem():
+        result = runner.invoke(
+            main_cli.main,
+            [
+                "--test-mode",
+                "--prefix",
+                use_prefix,
+                "--token",
+                token,
+                "--user",
+                user,
+                "--platform",
+                use_platform,
+                "dataformats",
+            ]
+            + list(args),
+        )
+    if result.exit_code != 0:
+        click.echo(result.output)
+    return result.exit_code
 
 
 @slow
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_remote_list():
-  nose.tools.eq_(call('list', '--remote'), 0)
-
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_local_list():
-  nose.tools.eq_(call('list'), 0)
+    nose.tools.eq_(call("list", "--remote"), 0)
 
 
 @slow
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_pull_one():
-  obj = 'system/bounding_box_video/1'
-  nose.tools.eq_(call('pull', obj, prefix=tmp_prefix), 0)
-  s = Storage(tmp_prefix, obj)
-  assert s.exists()
+    obj = "system/bounding_box_video/1"
+    nose.tools.eq_(call("pull", obj, prefix=tmp_prefix), 0)
+    s = Storage(tmp_prefix, obj)
+    nose.tools.assert_true(s.exists())
 
 
 @slow
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_pull_all():
-  nose.tools.eq_(call('pull', prefix=tmp_prefix), 0)
+    nose.tools.eq_(call("pull", prefix=tmp_prefix), 0)
 
 
 @slow
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_diff():
-  obj = 'system/integer/1'
-  nose.tools.eq_(call('pull', obj, prefix=tmp_prefix), 0)
+    obj = "system/integer/1"
+    nose.tools.eq_(call("pull", obj, prefix=tmp_prefix), 0)
 
-  # quickly modify the user dataformat by emptying it
-  f = DataFormat(tmp_prefix, obj)
-  f.data['value'] = 'int64'
-  f.write()
+    # quickly modify the user dataformat by emptying it
+    f = DataFormat(tmp_prefix, obj)
+    f.data["value"] = "int64"
+    f.write()
 
-  nose.tools.eq_(call('diff', obj, prefix=tmp_prefix), 0)
+    nose.tools.eq_(call("diff", obj, prefix=tmp_prefix), 0)
 
 
 @slow
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_status():
-  test_diff()
-  test_pull_one()
-  nose.tools.eq_(call('status', prefix=tmp_prefix), 0)
-
-
-def test_check_valid():
-  obj = 'user/3d_array_of_dataformat/1'
-  nose.tools.eq_(call('check', obj), 0)
-
-
-def test_check_invalid():
-  obj = 'system/invalid/1'
-  nose.tools.eq_(call('check', obj), 1)
-
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_create(obj=None):
-  obj = obj or 'user/newformat/1'
-  nose.tools.eq_(call('create', obj, prefix=tmp_prefix), 0)
-  s = Storage(tmp_prefix, obj)
-  assert s.exists()
-  return s
-
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_new_version():
-  obj = 'user/newformat/1'
-  obj2 = 'user/newformat/2'
-  test_create(obj)
-  nose.tools.eq_(call('version', obj, prefix=tmp_prefix), 0)
-  s = Storage(tmp_prefix, obj2)
-  assert s.exists()
-
-  # check version status
-  with Selector(tmp_prefix) as selector:
-    assert selector.version_of('dataformat', obj2) == obj
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_fork():
-  obj = 'user/newformat/1'
-  obj2 = 'user/different/1'
-  test_create(obj)
-  nose.tools.eq_(call('fork', obj, obj2, prefix=tmp_prefix), 0)
-  s = Storage(tmp_prefix, obj2)
-  assert s.exists()
-
-  # check fork status
-  with Selector(tmp_prefix) as selector:
-    assert selector.forked_from('dataformat', obj2) == obj
-
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_delete_local():
-  obj = 'user/newformat/1'
-  storage = test_create(obj)
-  nose.tools.eq_(call('rm', obj, prefix=tmp_prefix), 0)
-  assert not storage.exists()
-
-
-@nose.tools.with_setup(teardown=cleanup)
-def test_delete_local_unexisting():
-  obj = 'user/newformat/1'
-  storage = Storage(tmp_prefix, obj)
-  assert not storage.exists()
-
-  nose.tools.eq_(call('rm', obj, prefix=tmp_prefix), 1)
-  assert not storage.exists()
+    test_diff()
+    test_pull_one()
+    nose.tools.eq_(call("status", prefix=tmp_prefix), 0)
 
 
 @nose.tools.with_setup(teardown=cleanup)
 @skipif(disconnected, "missing test platform (%s)" % platform)
 def test_push_and_delete():
-  obj = 'user/newobject/1'
-  test_create(obj)
-
-  # now push the new object and then delete it remotely
-  nose.tools.eq_(call('push', obj, prefix=tmp_prefix), 0)
-  nose.tools.eq_(call('rm', '--remote', obj, prefix=tmp_prefix), 0)
+    obj = "user/newobject/1"
+    TestDataFormatLocal.create(obj)
+
+    # now push the new object and then delete it remotely
+    nose.tools.eq_(call("push", obj, prefix=tmp_prefix), 0)
+    nose.tools.eq_(call("rm", "--remote", obj, prefix=tmp_prefix), 0)
+
+
+class TestDataFormatLocal(core.AssetLocalTest):
+    storage_cls = Storage
+    asset_type = "dataformat"
+    object_map = {
+        "valid": "user/3d_array_of_dataformat/1",
+        "invalid": "user/invalid/1",
+        "create": "user/new_dataformat/1",
+        "new": "user/new_dataformat/2",
+        "fork": "user/forked_dataformat/1",
+    }